You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
In some cases (request aborting?) the request() function seems to return a non-Err error in the Left branch.
In line 131 we use .catch() to catch all errors throwed by the previous fetch call, which should be already transformed in Err objects (ref. line 128).
This seems to not cover all possible cases: the toRequestError() transformation maybe should be moved in the .catch() block...
Current behavior request() can return TaskEither.Left<Error> when fetch throws error.
Expected behavior request() should return only TaskEither.Left<Err> when fetch throws error.
Environment:
OS: All
Browser: All
Node/npm version: All
Typescript version: All
The text was updated successfully, but these errors were encountered:
Description
In some cases (request aborting?) the
request()
function seems to return a non-Err
error in theLeft
branch.In line 131 we use
.catch()
to catch all errors throwed by the previousfetch
call, which should be already transformed inErr
objects (ref. line 128).This seems to not cover all possible cases: the
toRequestError()
transformation maybe should be moved in the.catch()
block...Current behavior
request()
can returnTaskEither.Left<Error>
whenfetch
throws error.Expected behavior
request()
should return onlyTaskEither.Left<Err>
whenfetch
throws error.Environment:
The text was updated successfully, but these errors were encountered: