Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync renovate preset #6

Open
viceice opened this issue Oct 20, 2021 · 3 comments
Open

Sync renovate preset #6

viceice opened this issue Oct 20, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@viceice
Copy link
Member

viceice commented Oct 20, 2021

We should check and sync the shared preset if its upda-to-date with renovatebot/.github.

/cc @HonkingGoose

@viceice viceice added the enhancement New feature or request label Oct 20, 2021
@rarkins
Copy link
Member

rarkins commented Oct 20, 2021

Up to date how?

@viceice
Copy link
Member Author

viceice commented Oct 20, 2021

i think we've some more recent changes in our renovate org, which i've not replicated to this repo.
So we should compare and add any missing changes.

@HonkingGoose
Copy link
Contributor

Here are the differences between the Renovate default.json and the Containerbase default.json:

diff --git a/default.json b/default.json
--- default.json
+++ default.json
@@ -1,7 +1,7 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
-  "description": "Default preset for use with Renovate's repos",
+  "description": "Default preset for use with containerbase's repos",
   "extends": [
     "config:base",
     ":maintainLockFilesWeekly",
     ":rebaseStalePrs",
@@ -16,9 +16,8 @@
   "automergeType": "branch",
   "dependencyDashboard": true,
   "prCreation": "not-pending",
   "rebaseWhen": "behind-base-branch",
-  "internalChecksFilter": "strict",
   "packageRules": [
     {
       "description": "Require dashboard approval for major updates except Renovate",
       "excludePackagePatterns": ["^renovate(bot)?($|/)"],
@@ -48,9 +47,8 @@
       "matchPaths": [".md"],
       "extends": ["schedule:weekly"],
       "automerge": true,
       "stabilityDays": 0,
-      "separateMajorMinor": false,
       "commitMessageTopic": "references to {{{depName}}}",
       "semanticCommitType": "docs",
       "semanticCommitScope": null,
       "additionalBranchPrefix": "docs-"
@@ -81,9 +79,9 @@
       "matchDatasources": ["npm"],
       "matchPackageNames": ["aws-sdk"],
       "matchPackagePatterns": ["^@aws-sdk\\/"],
       "dependencyDashboardApproval": true
-    },
+    },    
     {
       "description": "Only patch updates on renovate rebuild trigger files",
       "matchFiles": ["renovate.Dockerfile"],
       "separateMinorPatch": true
@@ -132,9 +130,9 @@
     {
       "description": "Update version: variables in workflows",
       "fileMatch": ["^\\.github\\/workflows\\/[^/]+\\.ya?ml$"],
       "matchStrings": [
-        "\\s+version: (?<currentValue>.+?) #renovate: datasource=(?<datasource>[a-z-]+?) depName=(?<depName>.+?)(?: lookupName=(?<lookupName>.+?))?(?: versioning=(?<versioning>[a-z-]+?))?\\s"
+        "^\\s+version: (?<currentValue>.*) #renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)(?: versioning=(?<versioning>.*?))?\\s"
       ]
     }
   ]
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants