Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create Koji Build object, let OSBS create it using Content Generator API #27

Closed
twaugh opened this issue Mar 17, 2016 · 0 comments

Comments

@twaugh
Copy link
Member

twaugh commented Mar 17, 2016

Currently, the koji-containerbuild 'buildContainer' task creates a Koji Build object, and the 'createContainer' task starts the OSBS build.

Instead, the Build Object should be created by OSBS. In this new scheme, koji-containerbuild does not need to create a Koji Build object at all.

It will still need to stream build logs from the OSBS build, and cancel it when the Koji Task is cancelled.

I'm not clear enough on the difference between buildContainer and createContainer to say whether both are still needed. I tend towards thinking that they are, for multi-arch support(?).

This change is part of the new scheme for Koji integration, in which the Koji Build object is always created by CG import from atomic-reactor.

CC @maxamillion

See also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant