Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove necessity to link against C package #7

Open
stevvooe opened this issue Apr 4, 2017 · 13 comments
Open

Remove necessity to link against C package #7

stevvooe opened this issue Apr 4, 2017 · 13 comments

Comments

@stevvooe
Copy link
Member

stevvooe commented Apr 4, 2017

When I set out on this journey, the intent was to require only the btrfs headers and not actually link against btrfs. While the goal is somewhat achieved, we still require linking against libbtrfs to achieve correct struct alignment. This needs to be removed.

@stevvooe
Copy link
Member Author

stevvooe commented Apr 4, 2017

@vbatts PTAL

@vbatts
Copy link

vbatts commented Apr 4, 2017

fair. It's not so much the cgo usage, but rather the linking to libbtrfs (some distros don't provide the *.so along with the headers).

@stevvooe
Copy link
Member Author

stevvooe commented Apr 4, 2017

@vbatts Agreed!

@stevvooe
Copy link
Member Author

Actually, after #12, we are not technically linking against libbtrfs. The project does still require the header files.

@dennwc
Copy link

dennwc commented Apr 26, 2019

Would you consider merging with this library in either direction? It's in pure Go, the code is mostly a line-by-line port of btrfs-tools.

@crosbymichael
Copy link
Member

@dennwc I would be in favor of it

@dennwc
Copy link

dennwc commented May 7, 2019

Should I open the pull request to this repository? Or would you consider using the new library?

As an alternative, I can probably transfer the library to containerd.

@crosbymichael
Copy link
Member

Could we try replacing the lib with the btrfs snapshotter to run the snapshot test suite aginst to see if there are any issues or change in behavior?

@crosbymichael
Copy link
Member

The snapshotter lives in the main containerd repo

@dennwc
Copy link

dennwc commented May 7, 2019

Sure, will test it. Probably next week.

@dennwc
Copy link

dennwc commented May 17, 2019

@crosbymichael Test pass, please check the test branch.

@crosbymichael
Copy link
Member

@dennwc looks pretty good.

@stevvooe @dmcgowan what do you think about using, replacing this lib with a pure go implementation?

@dmcgowan
Copy link
Member

Pure Go sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants