-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove necessity to link against C package #7
Comments
@vbatts PTAL |
fair. It's not so much the cgo usage, but rather the linking to libbtrfs (some distros don't provide the *.so along with the headers). |
@vbatts Agreed! |
Actually, after #12, we are not technically linking against libbtrfs. The project does still require the header files. |
Would you consider merging with this library in either direction? It's in pure Go, the code is mostly a line-by-line port of |
@dennwc I would be in favor of it |
Should I open the pull request to this repository? Or would you consider using the new library? As an alternative, I can probably transfer the library to |
Could we try replacing the lib with the btrfs snapshotter to run the snapshot test suite aginst to see if there are any issues or change in behavior? |
The snapshotter lives in the main containerd repo |
Sure, will test it. Probably next week. |
@crosbymichael Test pass, please check the test branch. |
Pure Go sounds good |
When I set out on this journey, the intent was to require only the btrfs headers and not actually link against btrfs. While the goal is somewhat achieved, we still require linking against libbtrfs to achieve correct struct alignment. This needs to be removed.
The text was updated successfully, but these errors were encountered: