Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use uint32 for process exit status #318

Closed
mlaventure opened this issue Sep 19, 2016 · 0 comments
Closed

use uint32 for process exit status #318

mlaventure opened this issue Sep 19, 2016 · 0 comments
Assignees
@mlaventure

Comments

@mlaventure
Copy link
Contributor

mlaventure commented Sep 19, 2016 •
edited

Currently, the event code has a duplicated Event type defined that slightly differs from the one used by the grpc api: it has Status int instead of Status uint32

We should sync the 2 structs to avoid -1 values becoming 4294967295

Using types.Event directly is a bit annoying giving that it is using a protobuf.timestamp type. This would require extra conversion that could possibly fail. Atm this conversion is only needed in one place.
@mlaventure mlaventure self-assigned this Sep 19, 2016
@mlaventure mlaventure changed the title use types.Event everywhere use uint32 for process exit status Sep 19, 2016
@mlaventure mlaventure mentioned this issue Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlaventure mlaventure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlaventure