Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the compose ps command flagging process #1770

Closed
HanquanHq opened this issue Dec 27, 2022 · 2 comments
Closed

Refactor the compose ps command flagging process #1770

HanquanHq opened this issue Dec 27, 2022 · 2 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@HanquanHq
Copy link

HanquanHq commented Dec 27, 2022

What is the problem you're trying to solve

According to #1680, I want to refactor the compose ps command flagging process. Since #1702 is marked invalid, I open this issue for tracking purposes.

Describe the solution you'd like

  1. Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  2. Create some file in pkg/api/cmd/${cmd}, and move the command entry point in real into this package
  3. Create new docs in docs/reference/api/${cmd}_types.md, and describe the field in CommandOption

Additional context

No response

@yuchanns
Copy link
Contributor

yuchanns commented Dec 27, 2022

Please go ahead.

Well, please open a PR directly and mention #1680 for tracking.

@AkihiroSuda AkihiroSuda added duplicate This issue or pull request already exists and removed kind/feature labels Dec 27, 2022
@AkihiroSuda
Copy link
Member

Let me close one and track all commands in #1680

@AkihiroSuda AkihiroSuda closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants