Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw error when original image was missing when committing a running container #2295

Open
cardyok opened this issue Jun 13, 2023 · 2 comments

Comments

@cardyok
Copy link

cardyok commented Jun 13, 2023

What is the problem you're trying to solve

I'm not sure whether this is appropriate or not.

When image of a running container is deleted, should this container still be available for commit?

I think in current containerd design this is doable in two ways.

  1. reconstruct the content, create diff, ingest into content store and recreate layers for the newly committed image (history of original image will be lost)
  2. if image is missing, ask user to provide credentials for original image repo and refetch the missing layers.

there are also similar cases when image is not deleted while contents of some layers are missing (ctr image check image is incomplete), these cases can also be covered.

Describe the solution you'd like

Some feedback about this feature.

Additional context

No response

@AkihiroSuda
Copy link
Member

reconstruct the content, create diff, ingest into content store and recreate layers for the newly committed image (history of original image will be lost)

SGTM

@cardyok
Copy link
Author

cardyok commented Jun 13, 2023

reconstruct the content, create diff, ingest into content store and recreate layers for the newly committed image (history of original image will be lost)

SGTM

Okk, will work on the implementation. thx for replying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants