Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACVLAN support? #378

Closed
thediveo opened this issue Sep 21, 2021 · 3 comments · Fixed by #836
Closed

MACVLAN support? #378

thediveo opened this issue Sep 21, 2021 · 3 comments · Fixed by #836
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@thediveo
Copy link
Contributor

Some of today's Docker scenarios require granting specific containers direct data-link layer ("MAC") access, as opposed to nat'ed IP access. Examples are not only (infamous?) license server containers, but also non-IP protocol-based applications, such as in some industrial environments. Docker comes with its CNM "macvlan" driver and the CNI "driver" base also supports MACVLAN.

At the moment (as of commit 2895d60) does not understand the -d option when creating a new network: for Docker, -d specifies the type of CNM driver to create a new network with. nerdctl compose also catches these case that try to specify a non-bridge network driver and blocks such projects from deployment.

Please support MACVLAN networks next to bridge networks in nerdctl for improved Docker-compatibility.

@AkihiroSuda AkihiroSuda added enhancement New feature or request help wanted Extra attention is needed labels Sep 21, 2021
@AkihiroSuda
Copy link
Member

Please support MACVLAN networks next to bridge networks in nerdctl for improved Docker-compatibility.

Feel free to open PR

@AkihiroSuda
Copy link
Member

Implemented in #836

@AkihiroSuda AkihiroSuda linked a pull request Mar 7, 2022 that will close this issue
@thediveo
Copy link
Contributor Author

thediveo commented Mar 7, 2022

Thank you very much! I'll see to put it through the paces of some unit tests on our side. Once again, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants