-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspect image of container for better idempotency #39
Comments
Is there a recommeded workaround for this issue? |
@jaudriga actually it's an enhancement, that "nice to have". But idempotency with image should be fine now. Which issue do you hit with latest version? |
@sshnaidm while idempotency with
I actually see that behavior for most of my containers ( So, considering I am not doing anything wrong, my question is can I somehow use |
@jaudriga can you please paste your playbook for reproducing? Or at least the part with |
@sshnaidm the following recreates the container on every run with the above diff:
|
@sshnaidm thanks for working on this so fast. Now.. it seems to handle locally mounted folders well. However, it does not seem to have resolved the issue with the image name:
(In the meantime I switched from mounting the storage folder on the local filesystem to using a volume I created via The following is the new code:
|
@jaudriga thanks, you provide very good cases :) Will look asap. |
@jaudriga let me understand please the image issue better, because it's not reproducible for me: -image - graphite-statsd
+image - graphite-statsd:1.1.7-2 What is image tag in first run and what is it in second one? |
@sshnaidm The issue seems to be resolved for me as well. Yeah :) . However, I am going to answer your questions in case anyone else will have a similar issue.
The image tag was the same in the first and the second run:
Sadly I did not document the output of
Arg. Sry I forgot to replace the above |
@jaudriga cool, I hope last patch solved it for you. Let me know please if there are any other issues. |
@sshnaidm I just tried out version 1.0.3 of this collection. It is working fine! Thank you :) . I noticed something of a follow-up issue for which I currently do not want to create a separate issue.. just wanted to let you know: When using
The diff showed the following reproducibly:
However, removing the trailing |
@jaudriga yes, podman remove all slashes in inspect. So we need to strip all ending slashes in input too. Will send a fix. |
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Podman container module should inspect image of container to understand better what are options will be set for container. It's required for better idempotency of podman_container module.
Steps to reproduce the issue:
workdir
,volume
and any other supported, it'll be non-default in container inspection.strict image
idempotency we'll need to check SHAs of various images.The text was updated successfully, but these errors were encountered: