Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UDP in diffparam_publish #75

Closed
xdbob opened this issue Jul 9, 2020 · 0 comments · Fixed by #76
Closed

Handle UDP in diffparam_publish #75

xdbob opened this issue Jul 9, 2020 · 0 comments · Fixed by #76
Assignees
Labels
bug/idempotency Bug related to idempotency of modules bug Something isn't working
Milestone

Comments

@xdbob
Copy link

xdbob commented Jul 9, 2020

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

When creating a podman container using containers.podman.podman_container with UDP ports
it is always recreated even when it is already on the target on the expected state.

Steps to reproduce the issue:

  1. Use podman_container to deploy a container with udp ports

  2. Re-run the playbook

Describe the results you received:

The container is re-created

Describe the results you expected:

The container should be left alone

Additional information you deem important (e.g. issue happens only occasionally):

Output of ansible --version:

ansible 2.9.10
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/xdbob/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.8/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.8.3 (default, May 17 2020, 18:15:42) [GCC 10.1.0]

Output of podman version:

Version:            1.9.3
RemoteAPI Version:  1
Go Version:         go1.14.2
OS/Arch:            linux/arm64

Output of podman info --debug:

debug:
  compiler: gc
  gitCommit: ""
  goVersion: go1.14.2
  podmanVersion: 1.9.3
host:
  arch: arm64
  buildahVersion: 1.14.9
  cgroupVersion: v2
  conmon:
    package: conmon-2.0.18-1.fc32.aarch64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.18, commit: d524a9da2a836de897ccb260f1afe1cae44f1cb4'
  cpus: 4
  distribution:
    distribution: fedora
    version: "32"
  eventLogger: file
  hostname: paradise
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.6.19-300.fc32.aarch64
  memFree: 28033024
  memTotal: 984604672
  ociRuntime:
    name: crun
    package: crun-0.13-2.fc32.aarch64
    path: /usr/bin/crun
    version: |-
      crun version 0.13
      commit: e79e4de4ac16da0ce48777afb72c6241de870525
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  os: linux
  rootless: false
  slirp4netns:
    executable: ""
    package: ""
    version: ""
  swapFree: 391966720
  swapTotal: 468996096
  uptime: 166h 48m 36.49s (Approximately 6.92 days)
registries:
  search:
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - docker.io
store:
  configFile: /etc/containers/storage.conf
  containerStore:
    number: 1
    paused: 0
    running: 1
    stopped: 0
  graphDriverName: overlay
  graphOptions:
    overlay.mountopt: nodev,metacopy=on
  graphRoot: /var/lib/containers/storage
  graphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "true"
  imageStore:
    number: 2
  runRoot: /var/run/containers/storage
  volumePath: /var/lib/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):

podman-1.9.3-1.fc32.aarch64

[...snip]

** task informations **

The task looks like this:

  containers.podman.podman_container:
    name: unifi-controller
    image: 'linuxserver/unifi-controller:latest'
    state: present
    ports:
      - '3478:3478/udp'
      - '10001:10001/udp'
      - '8080:8080'
      - '8443:8443'
      - '1900:1900/udp'
    volumes:
      - '{{ unifi_dir }}:/config'
    security_opt:
      - 'seccomp=unconfined'

bug tracking

I've backtracked the bug to diffparam_publish, see the content of the diffs dict from the different method:

{
    "before": {
        "publish": [
            "10001:10001",
            "1900:1900",
            "3478:3478",
            "8080:8080",
            "8443:8443"
        ]
    },
    "after": {
        "publish": [
            "10001:10001/udp",
            "1900:1900/udp",
            "3478:3478/udp",
            "8080:8080",
            "8443:8443"
        ]
    }
}
@sshnaidm sshnaidm added bug Something isn't working bug/idempotency Bug related to idempotency of modules labels Jul 9, 2020
@sshnaidm sshnaidm self-assigned this Jul 9, 2020
@sshnaidm sshnaidm added this to the 1.1.0 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/idempotency Bug related to idempotency of modules bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants