Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: podman build --secret should support env as a source like buildx #4561

Closed
csschwe opened this issue Feb 6, 2023 · 5 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR

Comments

@csschwe
Copy link

csschwe commented Feb 6, 2023

Feature request description

Allow use of environment variables for podman build --secret in order to maintain feature parity with buildx

Suggest potential solution

podman build --secret=id=id,env=ENVIRONMENT_VARIABLE

Have you considered any alternatives?

It is possible to write temporary files, but this does not maintain feature parity with buildx

Additional context

docker/buildx#927

https://docs.docker.com/engine/reference/commandline/buildx_build/#secret

@csschwe csschwe added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 6, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

@flouthoc PTAL
@csschwe Interested in opening a PR?

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

This is a buildah issue so moving it over there.

@rhatdan rhatdan transferred this issue from containers/podman Feb 6, 2023
@csschwe
Copy link
Author

csschwe commented Feb 6, 2023

Looks like this is supported on Linux currently. But does not work with podman on MacOS.

c8002d9#diff-1ff945f9566b4296b404ee43b37ff16d62f13c90fe1a1dc040693524be03ea9b

It looks like podman is not passing the environment variables as expected on MacOS

@csschwe
Copy link
Author

csschwe commented Feb 6, 2023

#3598

@csschwe
Copy link
Author

csschwe commented Feb 6, 2023

Based on what I am seeing I think I should re-open this as a MacOS bug with podman build --secrets when using environment variables.

@csschwe csschwe closed this as completed Feb 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR
Projects
None yet
Development

No branches or pull requests

2 participants