Add support for passing auth creds via fd #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by ostreedev/ostree-rs-ext#413 which is in turn an adaption of code that lives in rpm-ostree today from coreos/rpm-ostree@d661e8f which aims to support privilege separation. This doesn't lower privilege separation into this project (yet), just aids in passing data across boundaries. Signed-off-by: Colin Walters <walters@verbum.org>
|
LGTM |
jmarrero
reviewed
Dec 19, 2022
| let auth_option_count = [ | ||
| config.authfile.is_some(), | ||
| config.auth_data.is_some(), | ||
| config.auth_anonymous, |
There was a problem hiding this comment.
I wonder if this will always be > 1. /me looks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by ostreedev/ostree-rs-ext#413 which is in turn an adaption of code that lives in rpm-ostree today from coreos/rpm-ostree@d661e8f which aims to support privilege separation.
This doesn't lower privilege separation into this project (yet), just aids in passing data across boundaries.