Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crun hangs when an OCI hook exists non-zero #129

Closed
vrothberg opened this issue Oct 8, 2019 · 10 comments
Closed

crun hangs when an OCI hook exists non-zero #129

vrothberg opened this issue Oct 8, 2019 · 10 comments
Assignees

Comments

@vrothberg
Copy link
Member

Didn't look into the code yet but it's a reproducer in 100 percent of the cases.

@giuseppe
Copy link
Member

giuseppe commented Oct 8, 2019

@vrothberg had a chance to try with the master version and the fix for OCI hooks that went in?

@vrothberg
Copy link
Member Author

Yes, still happening on my machine.

@giuseppe
Copy link
Member

giuseppe commented Oct 8, 2019

could you provide me the reproducer?

@vrothberg
Copy link
Member Author

I can reproduce on F31 with the latest crun (master) and the hook from https://github.com/containers/oci-seccomp-bpf-hook. A quick reproducer is to let main() of the hook do an os.Exit(1). The symptom is that podman/crun will hang.

@giuseppe
Copy link
Member

giuseppe commented Oct 9, 2019

could you quickly verify what processes are running? Is the "podman cleanup" process running?

@giuseppe
Copy link
Member

giuseppe commented Oct 9, 2019

the issue I am seeing can be reproduced with:

$ echo "exit 1" >> /tmp/runtime.sh
$ chmod +x /tmp/runtime.sh
$ podman --runtime /tmp/runtime.sh run --rm -ti alpine true

podman hangs

@giuseppe
Copy link
Member

giuseppe commented Oct 9, 2019

the issue I've seen is fixed with: containers/conmon#76

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2019

PR Is closed, could you guys build a new conmon and verify that this issue is fixed. Then lets get the new conmon released to Fedora 31.

@vrothberg
Copy link
Member Author

I can confirm that it's an issue in conmon. Thanks for looking into it, @giuseppe!

@vrothberg
Copy link
Member Author

containers/conmon#76 works but I'm not satisfied with the error...

Error: error reading container (probably exited) json message: EOF

Usually, we get better errors. I will experiment a bit to see what might trigger it. Ultimately, I consider this specific issue to be solved and will close the issue. Again, thanks @giuseppe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants