merge with runctst

[ghost]

In the runc era, there is a testsuite called runctst that has been matured in testing on RHEL and occasionally Fedora, which depend only on skopeo and python3-psutils.

crun has its own tests which are similar which seems have less testing coverage than runctst. Do you think it make sense to merge runctst into the crun tests to have one single python file that could use for regression testing?

[rhatdan]

Yes I think that is a great idea.

[ghost]

OK. Moreover, I will be looking into rewriting all the tests in C by which crun is written. With a bit luck, it might end up getting ride of dependencies on skopeo and python3-psutils.

[giuseppe]

@CAILCA yes thanks, that will be helpful. I've not added more tests as for Travis I am already using the oci-validation tests and the libpod tests.

Is there any reason why you'd like to drop these dependencies? I think it is fine to have them for the tests. Keeping the tests in Python is much nicer than handling JSON in C.

[ghost]

OK, stick with Python is probably fine then. The original thought was that since the purpose here is to test crun, so we don't need to spend time on dealing bugs in skopeo. For python3-psutils, it is not part of standard library and has to install separately, but no biggies.

[giuseppe]

@CAILCA is there any work going on for this issue?

[ghost]

Unfortunately, no. I have been buried with something else at the moment.

[rhatdan]

Totally untested
ocitst.py

Basically change all references to 'runc' to oci and then set oci based on args[0] of the command or based on environment variable or default to runc.

[giuseppe]

@CAILCA any movement here or can we close this issue?

[ghost]

I don't think I'll get to this now. Unless there is someone else to pick it up, feel free to close it.

[giuseppe]

ok thanks, let's reopen if things change