-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating vendored dependencies breaks the build #42
Comments
That's right @dfaggioli :) You can reproduce this with:
So either you need to pin to an exact version of cpuid, or maybe there is a fix in a newer version? There seems to be a different build error on latest main. Hope that helps! |
Hi! Those issues should be fixed in latest upstream code. Is it also failing for you with it? |
Hi there! It works with the latest upstream commits, but the problem is that on the released version it fails, and because it's a distro ... well, the maintainers prefer to use the released version. Is there a schedule for when the next release will be that we can update to? |
I see. We're about to introduce some breaking changes in the library in |
I've just tagged |
Hey @slp ! Great, thank you very much for the tag. I'll update our packages to 0.1.8 ASAP. Hopefully, I'll move stay up to date even when you release 0.2.0, as Tumbleweed is a rolling one, but let's see (and let's fix this for now) |
Thank you both for your help ❤️ |
I've just noticed Linux-aarch64 is broken on |
Ah, ok... Just seen this only now. And in fact, I was about to report this:
:-) Thanks again for helping us with this. I'll try the update again when it's fixed |
I've created the |
Ok, great! I'm also done, and I confirm that both x86 and aarch64 are green. I think we can close this issue :-) |
Hi @slp ! :-) So, just ad a foreword, I'm not yet that much into Rust myself, so forgive any inaccuracy/incorrectness of the explanation of the problem.
That said, in openSUSE, we do automatic updates of the vendored dependencies, for Rust packages (I think!). Doing that for libkrun causes some build error.
I believe you should be able to see what happens via this link:
https://build.opensuse.org/build/home:firstyear:branches:Virtualization/openSUSE_Tumbleweed/x86_64/libkrun/_log
But, just in case you don't, or if it disappears, here's what I think is the most relevant part:
And our Rust maintainer (hello @Firstyear :-D) believes this is better dealt with here, upstream. What do you think?
The text was updated successfully, but these errors were encountered: