podman run --env breaks on comma-separated values

[michaeladler]

/kind bug

Description

podman run --env "key=value" splits value if value is comma-separated.

Steps to reproduce the issue:

$ podman run --rm -it --env "no_proxy=a,b" docker.io/busybox /bin/sh -c env

Describe the results you received:

no_proxy=a
b=
...

Describe the results you expected:

no_proxy=a,b
...

Additional information you deem important (e.g. issue happens only occasionally):

Works in docker (alias podman=docker). I have tried escaping value in different ways but without any success.

Output of podman version:

Version:            1.1.2
RemoteAPI Version:  1
Go Version:         go1.11.5
Built:              Mon Mar 18 09:36:16 2019
OS/Arch:            linux/amd64

Output of podman info --debug:

debug:
  compiler: gc
  git commit: ""
  go version: go1.11.5
  podman version: 1.1.2
host:
  BuildahVersion: 1.7.1
  Conmon:
    package: Unknown
    path: /nix/store/hcmzdrd81zv2h7jcclx1d0c8yrjlzjlr-conmon-unstable-2019-02-15/bin/conmon
    version: 'conmon version , commit: '
  Distribution:
    distribution: nixos
    version: 19.03.git.3574dbb
  MemFree: 10057375744
  MemTotal: 16668540928
  OCIRuntime:
    package: Unknown
    path: /nix/store/gl511zshm42p1h0rw0f5f2mjh41dv3w0-runc-1.0.0-rc6-bin/bin/runc
    version: |-
      runc version 1.0.0-rc6
      spec: 1.0.1-dev
  SwapFree: 0
  SwapTotal: 0
  arch: amd64
  cpus: 8
  hostname: redacted
  kernel: 4.20.16
  os: linux
  rootless: true
  uptime: 38m 30.47s
insecure registries:
  registries: []
registries:
  registries:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
store:
  ConfigFile: redacted
  ContainerStore:
    number: 13
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mount_program=/run/current-system/sw/bin/fuse-overlayfs
  GraphRoot: redacted
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 8
  RunRoot: /run/user/redacted
  VolumePath: redacted

Additional environment details (AWS, VirtualBox, physical, etc.):

Physical.

[giuseppe]

PR here: #2717

[michaeladler]

That was quick. Thanks @giuseppe.