Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman run --mount "ro=false" results in read-only mount #2980

Closed
caffeinejolt opened this issue Apr 19, 2019 · 5 comments · Fixed by #3738
Closed

podman run --mount "ro=false" results in read-only mount #2980

caffeinejolt opened this issue Apr 19, 2019 · 5 comments · Fixed by #3738
Assignees
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@caffeinejolt
Copy link

podman-0.12.1.2-2.git9551f6b.el7.centos.x86_64
centos-release-7-6.1810.2.el7.centos.x86_64

If I do not specify any "ro" value - it does default to writable. However, the docs indicate that "ro=false" is the default - but if I specify the default, I end up with a read-only mount.

On a side-note, the docs don't really state the difference between --mount and --volume - if you read man podman-run, the reader is left to assume they are two ways of specifying a bind mount - is there any functional difference? Or is it all the same bind mount in the end?

@mheon
Copy link
Member

mheon commented Apr 19, 2019 via email

@mheon
Copy link
Member

mheon commented Apr 25, 2019

There's a very large rework to the --mount flag going in at #2959 - a little too large for me to be comfortable adding more to it - but once it lands I'll get a fix for this in.

The issue is that we're not checking if some mount flags (ro, rw, probably more) accept an argument, so if we see them we unconditionally toggle read-only on.

@mheon mheon self-assigned this Apr 25, 2019
@caffeinejolt
Copy link
Author

Cool - I would rate this as a pretty low priority fix anyways since there are easy workarounds.

@rhatdan
Copy link
Member

rhatdan commented Aug 5, 2019

@caffeinejolt @mheon is this still a bug?

@mheon
Copy link
Member

mheon commented Aug 5, 2019

Yes. I'll work on this one tomorrow.

mheon added a commit to mheon/libpod that referenced this issue Aug 6, 2019
The 'podman run --mount' flag previously allowed the 'ro' option
to be specified, but was missing the ability to set it to a bool
(as is allowed by docker). Add that. While we're at it, allow
setting 'rw' explicitly as well.

Fixes containers#2980

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
mheon added a commit to mheon/libpod that referenced this issue Aug 6, 2019
The 'podman run --mount' flag previously allowed the 'ro' option
to be specified, but was missing the ability to set it to a bool
(as is allowed by docker). Add that. While we're at it, allow
setting 'rw' explicitly as well.

Fixes containers#2980

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
mheon added a commit to mheon/libpod that referenced this issue Aug 6, 2019
The 'podman run --mount' flag previously allowed the 'ro' option
to be specified, but was missing the ability to set it to a bool
(as is allowed by docker). Add that. While we're at it, allow
setting 'rw' explicitly as well.

Fixes containers#2980

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
mheon added a commit to mheon/libpod that referenced this issue Aug 7, 2019
The 'podman run --mount' flag previously allowed the 'ro' option
to be specified, but was missing the ability to set it to a bool
(as is allowed by docker). Add that. While we're at it, allow
setting 'rw' explicitly as well.

Fixes containers#2980

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
gabibeyer pushed a commit to gabibeyer/libpod that referenced this issue Aug 15, 2019
The 'podman run --mount' flag previously allowed the 'ro' option
to be specified, but was missing the ability to set it to a bool
(as is allowed by docker). Add that. While we're at it, allow
setting 'rw' explicitly as well.

Fixes containers#2980

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
gabibeyer pushed a commit to gabibeyer/libpod that referenced this issue Aug 16, 2019
The 'podman run --mount' flag previously allowed the 'ro' option
to be specified, but was missing the ability to set it to a bool
(as is allowed by docker). Add that. While we're at it, allow
setting 'rw' explicitly as well.

Fixes containers#2980

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants