Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] Man pages are not complete for the remote client on Mac. #4922

Closed
ipbabble opened this issue Jan 21, 2020 · 12 comments
Closed

[Mac] Man pages are not complete for the remote client on Mac. #4922

ipbabble opened this issue Jan 21, 2020 · 12 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue

Comments

@ipbabble
Copy link
Collaborator

/kind bug

Description

On the Mac client (remote client) the complete set of manual pages is not available. Only the highest level man page is available. So for every podman man page you request you get the main podman man page.

Steps to reproduce the issue:

Example:
$ podman images
Error: Could not get runtime: dial unix /run/podman/io.podman: connect: no such file or directory
podman(1)() podman(1)()

NAME
podman - A Simple management tool for pods, containers and images.

SYNOPSIS
podman [options] command

Describe the results you received:
See above

Describe the results you expected:
I expect to see individual podman sub command man pages when requested.

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

$ podman version
Client:
Version:            1.6.1-dev
RemoteAPI Version:  1
Go Version:         go1.12.9
OS/Arch:            darwin/amd64

Service:
Version:            1.7.0
RemoteAPI Version:  1
Go Version:         go1.13.5
OS/Arch:            linux/amd64

Output of podman info --debug:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):

$ brew info cask podman
cask: stable 0.8.4, HEAD
Emacs dependency management
https://cask.readthedocs.org/
Not installed
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/cask.rb
==> Dependencies
Required: emacs ✘
==> Options
--HEAD
Install HEAD version
==> Analytics
install: 4,853 (30 days), 15,526 (90 days), 67,876 (365 days)
install-on-request: 4,776 (30 days), 15,244 (90 days), 66,479 (365 days)
build-error: 0 (30 days)

Error: No available formula with the name "podman"
Found a cask named "podman" instead.

podman: 1.6.0,28-gdac7889d
https://github.com/containers/libpod/
/usr/local/Caskroom/podman/1.6.0,28-gdac7889d (2 files, 47.4MB)
From: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/podman.rb
==> Name
podman
==> Artifacts
podman-v1.6.0-28-gdac7889d/podman (Binary)

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 21, 2020
@ipbabble
Copy link
Collaborator Author

FYI the version of Podman on my Fedora 31 server is:
'''

podman version

Version: 1.7.0
RemoteAPI Version: 1
Go Version: go1.13.5
OS/Arch: linux/amd64
'''

@mheon mheon added the remote Problem is in podman-remote label Jan 23, 2020
@mheon
Copy link
Member

mheon commented Jan 23, 2020

@jwhonce PTAL

@mheon mheon added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Jan 23, 2020
@rhatdan
Copy link
Member

rhatdan commented Jan 26, 2020

@ipbabble Could you open a PR to fix this? Not likely @jwhonce Will get to it soon, since he is concentrating on APIV2.

@vrothberg
Copy link
Member

Ping. I guess we had to bump the version of the Mac client as well, right?

@rhatdan
Copy link
Member

rhatdan commented Feb 18, 2020

@cevich I think this is because the new versions are not being built?

@cevich
Copy link
Member

cevich commented Feb 24, 2020

Hrmmm, I'm not sure about this one, @baude do you know where/how that homebrew package comes from?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jun 9, 2020

@ashley-cui Could you verify the man pages are available?

@ashley-cui
Copy link
Member

Looks like the manpages are not included in the tarball attached to the release. The remote manpages are compiled differently since I last took a look at them, but once I understand that the fix should be as simple as adding the manpages into the tarball and updating the homebrew ruby install code

@ashley-cui
Copy link
Member

@mheon Do you know how the podman-remote-darwin.tar.gz asset on the latest release was created? It looks like manpages are missing there but make podman-remote-darwin-release makes a .zip that has the correct manpages inside. If it's okay, I can just change that asset to the .zip that the make command creates and then update the homebrew formula; this should fix everything

@mheon
Copy link
Member

mheon commented Jun 11, 2020

The release tars are manually produced by me by means of make podman-remote-darwin and tarring the result. A specific make target that produces a tar or zip with appropriate contents would solve this.

@ashley-cui
Copy link
Member

ashley-cui commented Jun 15, 2020

Closed via Homebrew/homebrew-cask#84399

Part of issue is Mac has a quirk where man only takes in the first arg: man podman images will only display the manpage for podman, but man podman-images will give you the the manpage for podman images. But I also realized that the manpages haven't been on the homebrew packaged releases regardless, and that has been fixed

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue
Projects
None yet
Development

No branches or pull requests

7 participants