Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman 2.0 image load name:tag positional arg is no longer optional #6718

Closed
Musi13 opened this issue Jun 22, 2020 · 2 comments · Fixed by #6722
Closed

Podman 2.0 image load name:tag positional arg is no longer optional #6718

Musi13 opened this issue Jun 22, 2020 · 2 comments · Fixed by #6722
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@Musi13
Copy link

Musi13 commented Jun 22, 2020

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Running podman image load [-i image.tar] without specifying the image name produces Error: requires at least 1 arg(s), only received 0. The help string suggests this argument is supposed to be optional (as it was pre-2.0):

# podman image load --help
...
Usage:
  podman image load [flags] [NAME[:TAG]]

Steps to reproduce the issue:

  1. podman image load --input image.tar

Describe the results you received:

Error: requires at least 1 arg(s), only received 0

Describe the results you expected:

Getting image source signatures
...
Writing manifest to image destination
Storing signatures
Loaded image(s): ...

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Version:      2.0.0
API Version:  1
Go Version:   go1.13.8
Built:        Thu Jan  1 00:00:00 1970
OS/Arch:      linux/amd64

Output of podman info --debug:

host:
  arch: amd64
  buildahVersion: 1.15.0
  cgroupVersion: v1
  conmon:
    package: 'conmon: /usr/libexec/podman/conmon'
    path: /usr/libexec/podman/conmon
    version: 'conmon version 2.0.18, commit: '
  cpus: 2
  distribution:
    distribution: ubuntu
    version: "20.04"
  eventLogger: file
  hostname: localhost
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.4.0-37-generic
  linkmode: dynamic
  memFree: 6089273344
  memTotal: 8348975104
  ociRuntime:
    name: runc
    package: 'runc: /usr/sbin/runc'
    path: /usr/sbin/runc
    version: 'runc version spec: 1.0.1-dev'
  os: linux
  remoteSocket:
    path: /run/podman/podman.sock
  rootless: false
  slirp4netns:
    executable: ""
    package: ""
    version: ""
  swapFree: 0
  swapTotal: 0
  uptime: 58m 41.13s
registries:
  search:
  - docker.io
  - quay.io
store:
  configFile: /etc/containers/storage.conf
  containerStore:
    number: 0
    paused: 0
    running: 0
    stopped: 0
  graphDriverName: overlay
  graphOptions: {}
  graphRoot: /var/lib/containers/storage
  graphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  imageStore:
    number: 1
  runRoot: /var/run/containers/storage
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 1
  Built: 0
  BuiltTime: Thu Jan  1 00:00:00 1970
  GitCommit: ""
  GoVersion: go1.13.8
  OsArch: linux/amd64
  Version: 2.0.0

Package info (e.g. output of rpm -q podman or apt list podman):

root:~# apt list podman
Listing... Done
podman/unknown,now 2.0.0~1 amd64 [installed]
podman/unknown 2.0.0~1 arm64
podman/unknown 2.0.0~1 armhf
podman/unknown 2.0.0~1 s390x

Additional environment details (AWS, VirtualBox, physical, etc.):

Verified that this works as expected on 1.9.3:

root:~# dpkg -i podman_1.9.3~1_amd64.deb
dpkg: warning: downgrading podman from 2.0.0~1 to 1.9.3~1
(Reading database ... 41048 files and directories currently installed.)
Preparing to unpack podman_1.9.3~1_amd64.deb ...
Unpacking podman (1.9.3~1) over (2.0.0~1) ...
Setting up podman (1.9.3~1) ...
Processing triggers for man-db (2.9.1-1) ...
root:~# podman image load --input /tmp/image.tar
Getting image source signatures
Copying blob 280440e8f2cd skipped: already exists
...
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 22, 2020
@vrothberg vrothberg self-assigned this Jun 23, 2020
@vrothberg
Copy link
Member

Thanks a lot for the report, @Musi13 !

vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 23, 2020
Disable the args requirement of `image load`.  Instead of requiring a
lower bound, we really need an upper one with at most 1 argument.
Extend the system tests to prevent future regressions.

Fixes: containers#6718
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg
Copy link
Member

Opened #6722 to fix the issue.

vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 23, 2020
Disable the args requirement of `image load`.  Instead of requiring a
lower bound, we really need an upper one with at most 1 argument.
Extend the system tests to prevent future regressions.

Fixes: containers#6718
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 24, 2020
Disable the args requirement of `image load`.  Instead of requiring a
lower bound, we really need an upper one with at most 1 argument.
Extend the system tests to prevent future regressions.

Fixes: containers#6718
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants