WIP DONOT Merge - Test for single line Dockerfile #2007
Conversation
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/approved |
|
☔ The latest upstream changes (presumably #2090) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@TomSweeneyRedHat: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
@TomSweeneyRedHat Do we support Single Line Dockerfile in Podman now? |
|
We have vendored the latest buildah, so we should have this. |
|
Now that Buildah has been vendored, we should. I'll run a quick tests. |
|
Testing took longer than suspected, but one line Dockerfiles are now usable by Podman. |
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com
DO NOT MERGE THIS! I'm putting this change directly into vendor to see if the tests pass. If they do I'll make the change in the Buildah project and will then vendor Buildah into Podman.
This addresses #1993. Podman turns layers on by default with for build. The layer logic does not behave if there's only a one line Dockerfile given to the build, a commit is never done as the layer logic doesn't do a commit because it's waiting for the last of two ore more layers before doing so. If we have only one line in one Dockerfile that we're building, the most layers we will have is one, so just ignore layering.