Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in error message for x-podman.gidmap #963

Closed
freezurbern opened this issue Jun 10, 2024 · 1 comment
Closed

Typo in error message for x-podman.gidmap #963

freezurbern opened this issue Jun 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@freezurbern
Copy link

Describe the bug
x-podman.gidman should be x-podman.gidmap

# handle podman extension
if 'x-podman' in cnt:
raise ValueError(
'Configuration under x-podman has been migrated to x-podman.uidmap and '
'x-podman.gidman fields'
)

To Reproduce
Steps to reproduce the behavior:

docker-compose.yml

services:
  ubuntu:
    image: docker.io/library/ubuntu
    user: "1000:100"
    x-podman:
      uidmap:
        - 0:1:1000
        - 1000:0:1
        - 1001:1001:64536

commands

$ podman-compose version
podman-compose version 1.1.0
podman version 3.4.4

$ podman-compose up
Traceback (most recent call last):
  File "/home/user/.local/bin/podman-compose", line 3472, in <module>
    main()
  File "/home/user/.local/bin/podman-compose", line 3468, in main
    asyncio.run(async_main())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/user/.local/bin/podman-compose", line 3464, in async_main
    await podman_compose.run()
  File "/home/user/.local/bin/podman-compose", line 1740, in run
    retcode = await cmd(self, args)
  File "/home/user/.local/bin/podman-compose", line 2464, in compose_up
    podman_args = await container_to_args(compose, cnt, detached=args.detach)
  File "/home/user/.local/bin/podman-compose", line 1227, in container_to_args
    raise ValueError(
ValueError: Configuration under x-podman has been migrated to x-podman.uidmap and x-podman.gidman fields
@freezurbern freezurbern added the bug Something isn't working label Jun 10, 2024
@mokibit
Copy link
Contributor

mokibit commented Jun 14, 2024

@freezurbern, thanks for opening an issue!
Fixed in #965.
@p12tic this issue can be closed.

@p12tic p12tic closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants