Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM package for Fedora and EPEL #112

Closed
Conan-Kudo opened this issue Apr 15, 2022 · 27 comments
Closed

RPM package for Fedora and EPEL #112

Conan-Kudo opened this issue Apr 15, 2022 · 27 comments
Labels
kind/feature 💡 Issue for requesting a new feature lifecycle/stale

Comments

@Conan-Kudo
Copy link

Is your feature request related to a problem? Please describe

I'd like to be able to install Podman Desktop through DNF on Fedora or RHEL/CentOS, which also opens doors to being able to bundle/ship Podman Desktop in a container-focused spin or third-party remixes.

Describe the solution you'd like

This requires the Podman Desktop software to be packaged as an RPM and reviewed for inclusion in Fedora and EPEL.

Describe alternatives you've considered

No response

Additional context

As this is Electron-based, Fedora needs to package and ship an Electron runtime. Fortunately, @cryptomilk has gone through the effort of figuring that out and merely needs co-maintainers before he submits it for review. @thunderbirdtr noted on Twitter he'd help here, but more folks would be welcome. 😄

This ticket was suggested by @gbraad on Twitter to ensure we have this on the roadmap and prioritized properly.

@Conan-Kudo Conan-Kudo added the kind/feature 💡 Issue for requesting a new feature label Apr 15, 2022
@benoitf
Copy link
Collaborator

benoitf commented Apr 15, 2022

electron builder can provide RPM out of the box so we could enable this option but I'm not sure if it's the RPM you would expect ?

https://www.electron.build/configuration/linux

We could provide AppImage or Snap as well

@onuralpszr
Copy link

electron builder can provide RPM out of the box so we could enable this option but I'm not sure if it's the RPM you would expect ?

We would like to able install via "dnf" from Fedora repository. That's the RPM we looking for.

@rhatdan
Copy link
Member

rhatdan commented Apr 15, 2022

We will be packaging it for Fedora, but right now, it is being updated on a daily basis.
I would figure when it is declared 1.0.

@gbraad
Copy link
Member

gbraad commented Apr 16, 2022

Packages can be generated from our builds if needed
... Or package as flatpak? @benoitf WDYT?

@benoitf
Copy link
Collaborator

benoitf commented Apr 16, 2022

For sure flatpak or Snap packages can be added. It seems lot of people are interested by the GUI on Linux as well.

@rhatdan
Copy link
Member

rhatdan commented Apr 18, 2022

I want a standard RPM, so users can just do.

dnf -y install podman-desktop

And end up with Podman-desktop and podman installed on their box.

@gotmax23
Copy link

gotmax23 commented Sep 9, 2022

@rhatdan:

I want a standard RPM, so users can just do.

dnf -y install podman-desktop

That would be great.

@benoitf:

electron builder can provide RPM out of the box so we could enable this option but I'm not sure if it's the RPM you would expect ?

https://www.electron.build/configuration/linux

You can use Electron Builder to build a binary RPM, but not to ship it in the Fedora repositories. RPMs built like this are in no way compatible with Fedora's packaging guidelines or build system.

@cryptomilk
Copy link

I've packaged nodejs-electron and other dependencies to build electron apps in the openSUSE Build Service for Fedora:

https://build.opensuse.org/package/show/devel:languages:nodejs/nodejs-electron
https://build.opensuse.org/package/show/devel:languages:nodejs/app-builder

Here is an example how to build an electron app:
https://build.opensuse.org/package/show/network:im:signal/signal-desktop

@benoitf
Copy link
Collaborator

benoitf commented Sep 9, 2022

@cryptomilk are you interested in contributing RPM for Podman Desktop ?

@cryptomilk
Copy link

I don't have the time for it. But the work for electron is already done. A fedora maintainer is needed ...

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2022

@jnovy @lsm5 PTAL

@lsm5
Copy link
Member

lsm5 commented Sep 9, 2022

@rhatdan do we have anyone in the podman-desktop team that would like to become fedora maintainers? I can work with them, but I'd rather not be the point person for this.

@gotmax23
Copy link

gotmax23 commented Sep 9, 2022

Just to be clear, nodejs-electron isn't packaged in Fedora, either. Perhaps you can reach out on the Fedora devel mailing list to see if anyone is interested in helping out with that.

@lsm5
Copy link
Member

lsm5 commented Sep 15, 2022

Just to be clear, nodejs-electron isn't packaged in Fedora, either. Perhaps you can reach out on the Fedora devel mailing list to see if anyone is interested in helping out with that.

so nodejs seems to be cool with bundling afaict. https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/ . Can't electron be bundled into podman-desktop or does it need to live in a separate package?

@Conan-Kudo
Copy link
Author

Electron needs to be built as a shared dependency because it's a nodejs runtime platform extension. It's not pure JavaScript. The rest of Podman Desktop's dependencies can and should be bundled, but we definitely don't want to do that for Electron.

@lsm5
Copy link
Member

lsm5 commented Sep 15, 2022

Electron needs to be built as a shared dependency because it's a nodejs runtime platform extension. It's not pure JavaScript. The rest of Podman Desktop's dependencies can and should be bundled, but we definitely don't want to do that for Electron.

ack, makes sense. Thanks @Conan-Kudo

@lsm5
Copy link
Member

lsm5 commented Sep 15, 2022

I see another response on a different thread that electron depends on fetching prebuilt blobs at build time.

@rhatdan If that's still the case, we might be better off with a copr or continuing with obs, unless someone is really willing to invest time into this.

@Conan-Kudo
Copy link
Author

Electron can be built entirely from source, as @cryptomilk has done.

@cryptomilk
Copy link

We build electron completely from source for Fedora:

https://build.opensuse.org/package/show/devel:languages:nodejs/nodejs-electron

The OBS build runners don't have any network connectivity!

@jhoblitt
Copy link

+1 for flatpak

@jhoblitt
Copy link

It seems that flatpak already exists: https://podman-desktop.io/docs/Installation/linux-install

@benoitf
Copy link
Collaborator

benoitf commented Oct 25, 2022

@jhoblitt
Copy link

Confirmed the flatpak as working on F36.
Screenshot from 2022-10-25 10-27-24

@lsm5
Copy link
Member

lsm5 commented Nov 25, 2022

not an official package but I got a copr setup in case anyone wants to try: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-desktop/

@shivdhar
Copy link

I'm interested in being able to dnf install podman-desktop as well; it was rather surprising to see it hasn't landed yet. What are the steps I can can help out with to make this happen?

Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

Copy link
Contributor

This issue has been automatically closed because it has not had any further activity in the last 30 days. Thank you for your contributions!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature 💡 Issue for requesting a new feature lifecycle/stale
Projects
Archived in project
Development

No branches or pull requests

10 participants