feat: Allow to edit registries

[ankanroy-code]

UI - add feature : #156

make registries editable

Untitled.mp4

HOW I DID IT?
basic idea: delete the old registry create a new registry, using the old registry and the changed data.

• create a new component PreferncesEditRegistrieModal.svelte
• used the same logic as PreferencesRegistriesCreateRegistryModal.svelte
  why did i not used the same component?
  as it was looking more complicated to do! and had to add more rendering logic in the html part.

PROBLEMS?

• only when you change the URL in edit, it create a new registry, and dose not delete the old one.

Please let me know any changes you world like

[benoitf]

Hello @ankanroy-code and thanks for your contribution 🎉

To be able to merge pull requests on containers organization, commits need to be signed Off.
https://github.com/containers/podman-desktop/pull/198/checks?check_run_id=6863265316

[ankanroy-code]

@benoitf thanks i did it.

[slemeur]

Thanks for your contribution @ankanroy-code !!

[benoitf]

Hello, you should probably do a rebase as well of the branch to the main branch.

it looks like there are commits in your PR that are already in the current main branch

[ankanroy-code]

@benoitf hey i did a rebase of editmode to my main. did it work. i am new to git. so sorry,it taking time to understand what commands am i passing.

[benoitf]

@ankanroy-code it seems not. I mean, we shouldn't see the commits that are already in the main branch.

[ankanroy-code]

@benoitf should i make a new PR from the main?

[benoitf]

@ankanroy-code changing git history can be done in your branch. No need to create a new one. But if it's easier for you, you may try with a new one.
If you're not able to rebase properly I could attempt to do it.

[benoitf]

@ankanroy-code also probably we would need to share some stuff between the 'creation' and the 'update' component

[ankanroy-code]

@ankanroy-code changing git history can be done in your branch. No need to create a new one. But if it's easier for you, you may try with a new one. If you're not able to rebase properly I could attempt to do it.

@benoitf sorry for late reply, went to college today for the first time. Just came back. If you so the rebase, please do it, it would be great help.

[ankanroy-code]

@ankanroy-code also probably we would need to share some stuff between the 'creation' and the 'update' component

Can you give me some example? Or a bit more specific explanation. I am new, so the terms are not clear. I googled it, but could not understand the question.

[benoitf]

Can you give me some example? Or a bit more specific explanation. I am new, so the terms are not clear. I googled it, but could not understand the question.

The idea is that by having a common component, if for example we add a new parameter to the 'creation' panel then it's handled by the 'update/edit' part

[benoitf]

FYI I did rebase your branch

$ git remote add upstream https://github.com/containers/podman-desktop
$ git fetch upstream
$ git pull --rebase upstream main
$ git push -f origin editmode

[ankanroy-code]

@benoitf what is 'creation' panel and what is 'update/edit' part. If you can specify the code, it world be great.

[benoitf]

the filename has a typo (missing e in Preferences) and missing s at RegistrieS

[ankanroy-code]

FYI I did rebase your branch

$ git remote add upstream https://github.com/containers/podman-desktop
$ git fetch upstream
$ git pull --rebase upstream main
$ git push -f origin editmode

@benoitf hey I fixed it. Which brunch should I push my code to, Main or editmode.

[benoitf]

always push to editmode (this is a the branch used to create this Pull Request)

[ankanroy-code]

FYI I did rebase your branch

$ git remote add upstream https://github.com/containers/podman-desktop
$ git fetch upstream
$ git pull --rebase upstream main
$ git push -f origin editmode

@benoitf thxxxxxxx

[benoitf]

There is a PR check that is failing (linter/formatter)

Ensure to run the command yarn format:fix && yarn lint:fix

[ankanroy-code]

@benoitf I fixed the linter/formatter issue

[benoitf]

@ankanroy-code I don't see the modal file ( I see you removed the old file but in PR diff I don't see the new file)

[benoitf]

also I don't see any common code between create and edit modal that will lead to something harder to maintain

[ankanroy-code]

also I don't see any common code between create and edit modal that will lead to something harder to maintain

Working on. It will be over in 4 hours

[ankanroy-code]

@benoitf I made a common file for the functions that are reused

[benoitf]

I've added changes to your branch to use a single modal file (two mode: create or edit). It avoids to duplicate 200lines of code.
Also I've added update event (instead of having to perform remove and then add)

changes are there e458aa5

[ankanroy-code]

I've added changes to your branch to use a single modal file (two mode: create or edit). It avoids to duplicate 200lines of code. Also I've added update event (instead of having to perform remove and then add)

changes are there e458aa5

@benoitf Nice, It reduced a lot of code. Also fixed all the problems. Thanks!!! For your help.