Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode for terminals #7545

Open
Tracked by #4914
deboer-tim opened this issue Jun 10, 2024 · 3 comments
Open
Tracked by #4914

Light mode for terminals #7545

deboer-tim opened this issue Jun 10, 2024 · 3 comments
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

We use terminals in many places, they should all support light mode.

Describe the solution you'd like

Define any missing colors in the color registry and move all terminals to use them.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jun 10, 2024
@deboer-tim deboer-tim mentioned this issue Jun 10, 2024
46 tasks
@deboer-tim
Copy link
Collaborator Author

Related: #7596

@cdrage
Copy link
Contributor

cdrage commented Jun 13, 2024

For this issue, #7596 is regarding the editor but this issue is with regards to the terminal.

I'm assuming it'd make sense for custom terminal / editor themes to go in first, so that with light mode it could just be changing the configuration value of the theme for terminal / editor when the user toggles light / dark?

@deboer-tim
Copy link
Collaborator Author

For this issue, #7596 is regarding the editor but this issue is with regards to the terminal.

I'm assuming it'd make sense for custom terminal / editor themes to go in first, so that with light mode it could just be changing the configuration value of the theme for terminal / editor when the user toggles light / dark?

Probably? There might be a quicker path to (only) get light terminal/editor working, but agree it would be better to be able to point to theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement
Projects
None yet
Development

No branches or pull requests

4 participants