Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Experimental Light mode for 1.11.0 #7750

Open
cbr7 opened this issue Jun 20, 2024 · 9 comments
Open

Issues with Experimental Light mode for 1.11.0 #7750

cbr7 opened this issue Jun 20, 2024 · 9 comments
Labels
area/ui kind/bug 🐞 Something isn't working

Comments

@cbr7
Copy link
Contributor

cbr7 commented Jun 20, 2024

Bug description

It seems there are no light mode version for the pages access through buttons from the additional actions sections of the main pages (e.g Play Kubernets YAML button from Pods page), all these pages are displayed in dark mode in PD version 1.11

Screen.Recording.2024-06-20.at.09.42.43.mov

Operating system

macOS

Installation Method

Installer from website/GitHub releases

Version

next (development version)

Steps to reproduce

  1. Install PD 1.11
  2. Turn on light mode.
  3. Go to "Play Kubernets YAML" page (or any menu accessed from additional actions buttons)
  4. Notice the pages will be in dark mode.

Relevant log output

No response

Additional context

No response

@cbr7 cbr7 added kind/bug 🐞 Something isn't working area/ui labels Jun 20, 2024
@cbr7
Copy link
Contributor Author

cbr7 commented Jun 20, 2024

Additional note: I've also noticed that the notification on the dashboard that directs the user to create a podman machine is also shown in dark mode

image

Also of note that the podman machine creation workflow/menus are all in dark mode even if light mode is enabled

image image

@deboer-tim
Copy link
Collaborator

The dashboard supercharge section/banner is tracked via #7608.
Form pages are tracked via #7214.
Onboarding (machine creation) are covered through #7547 and #7548.
The only thing I see that isn't already tracked is the Notifications section, @cbr7 do you want to open up a separate issue so that it's not buried, or change the title to focus on that?

In general you can scan epic #4914 to see what's done for light mode and what is still being tracked.

@odockal
Copy link
Contributor

odockal commented Jun 20, 2024

@deboer-tim Idea is to track all what we find during testing here and then compare with what we already know about. Please wait a little :) We can then close in case nothing new appears - or open separated issues, wdyt?

@odockal odockal changed the title No light mode versions for additional actions menus in PD 1.11 Issues with Experimental Light mode for 1.11.0 Jun 20, 2024
@odockal
Copy link
Contributor

odockal commented Jun 21, 2024

My findings so far, what is missing:

  • Resources
    • Create New Cluster (Connection - machine, kind, sandbox, etc)
    • Connection -> Logs
    • Onboarding (again, any, will affect global onboarding - podman, compose, kubectl)
  • General
    • dropdowns
    • top Input box (aka press kube-context switch in system tray)
    • any xterm, terminal, yaml viewer, etc. is also missing
  • Dashboard
    • Notifications
  • Forms
    • Build Image
    • Run Image
    • Pull Image
    • Play Kube
    • Deploy to Kubernetes
    • Create Volume
  • Parts of the pages
    • Export Container - also, in containers details, it is missaligned on the page, it does not have its own page
    • Import container
    • Save Image
    • Load image
  • System Bar
    • Tasks
    • Feedback
    • Troubleshooting
    • Help

@odockal
Copy link
Contributor

odockal commented Jun 24, 2024

@deboer-tim We have now hopefully complete list of issue related to light mode. We need to compare that with epic for light mode.

@deboer-tim
Copy link
Collaborator

Epic is #4914 for reference. I did a quick comparison and I think the only thing were weren't tracking is the quick pick/top input box. Luca has fixed/PRs up for most of the forms in the current sprint, and we have ~half of the remaining work targeted to the next sprint.

@odockal
Copy link
Contributor

odockal commented Jun 25, 2024

@deboer-tim thanks! I will keep this open to compare in a while what all we got fixed.

@kpiwko
Copy link

kpiwko commented Jun 27, 2024

Extensions also have issues with light mode, e.g. bootc is still dark.

@deboer-tim
Copy link
Collaborator

Extensions also have issues with light mode, e.g. bootc is still dark.

The current bootc extension (v1.2.0) should have a light homepage and then a dark form (similar to most of Podman Desktop in 1.11), but extension issues are tracked in their own repos, e.g.:
containers/podman-desktop-extension-bootc#536 for bootc
and
containers/podman-desktop-extension-ai-lab#1209 for AI Lab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/bug 🐞 Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants