Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API /networks/{id} missing query parameters #10061

Closed
jwhonce opened this issue Apr 16, 2021 · 5 comments · Fixed by #10603
Closed

API /networks/{id} missing query parameters #10061

jwhonce opened this issue Apr 16, 2021 · 5 comments · Fixed by #10603
Assignees
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@jwhonce
Copy link
Member

jwhonce commented Apr 16, 2021

For compatibility, the following query parameters should be implemented:

  • verbose
  • scope

Any value for scope other than local should return a 400 error.

See #9126

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan rhatdan added Good First Issue This issue would be a good issue for a first time contributor to undertake. and removed stale-issue labels May 17, 2021
@rhatdan
Copy link
Member

rhatdan commented May 17, 2021

This would seem to be a good first issue, we would need volunteers for this. Or we can have interns look into it.

@jamesdube
Copy link

This would seem to be a good first issue, we would need volunteers for this. Or we can have interns look into it.

This looks like something I can do. I've tried to look into the background of the issue, is this adding query parameters to filter networks?

@jwhonce jwhonce changed the title API /networks missing query parameters API /networks/{id} missing query parameters May 18, 2021
@jwhonce
Copy link
Member Author

jwhonce commented May 18, 2021

@jamesdube The query parameters do filter the networks returned. Research is needed on:

  • how verbose changes the returned payload
  • which scopes podman most approximates, errors should be returned on non-supported values

See https://docs.docker.com/engine/api/v1.41/#operation/NetworkInspect for details. I look forward to your PR.

@jamesdube
Copy link

I get it now thanks, let me have a look

@cdoern cdoern self-assigned this Jun 7, 2021
@cdoern cdoern linked a pull request Jun 8, 2021 that will close this issue
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants