Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman farm update enhancement #20080

Closed
yuhuijiang opened this issue Sep 21, 2023 · 1 comment · Fixed by #20110
Closed

podman farm update enhancement #20080

yuhuijiang opened this issue Sep 21, 2023 · 1 comment · Fixed by #20110
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@yuhuijiang
Copy link
Contributor

Issue Description

"podman farm update --add testcon1 testfarm1" will perform successfully, even though the connection name "testcon1" not exist or the farm name "testfarm1" not exist.
this issue both exists in "podman farm update --add/--remove/--default"

Steps to reproduce the issue

Steps to reproduce the issue
1.[root@sweetpig-6 ~]# podman farm list
Name Connections Default
demo [] true
2.[root@sweetpig-6 ~]# podman system connection list
Name URI Identity Default
rhel86_aarch ssh://root@ampere-mtsnow-altra-01-vm-14.lab.eng.rdu2.redhat.com:22/run/podman/podman.sock false
rhel88_aarch ssh://root@arm-virt-02.lab.eng.pek2.redhat.com:22/run/podman/podman.sock false
rhel88_ppc64 ssh://root@ibm-p9z-06-lp10.khw3.lab.eng.bos.redhat.com:22/run/podman/podman.sock true
rhel88_s390 ssh://root@s390x-kvm-073.lab.eng.rdu2.redhat.com:22/run/podman/podman.sock false
3.[root@sweetpig-6 ~]# podman farm update --add testcon1 testfarm1
Farm "testfarm1" updated

Describe the results you received

Farm "testfarm1" updated

Describe the results you expected

podman should exit with error and prompt
WARN[0000] farm "testfarm1" doesn't exist; nothing to update
Error: failed to update farms ["testfarm1"]

podman info output

If you are unable to run podman info for any reason, please provide the podman version, operating system and its version and the architecture you are running.

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

Additional environment details

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting

@yuhuijiang yuhuijiang added the kind/bug Categorizes issue or PR as related to a bug. label Sep 21, 2023
@rhatdan
Copy link
Member

rhatdan commented Sep 21, 2023

@umohnani8 PTAL

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants