Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Podman machine builds do not enforce lint checks #21751

Closed
cevich opened this issue Feb 19, 2024 · 3 comments
Closed

MacOS Podman machine builds do not enforce lint checks #21751

cevich opened this issue Feb 19, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. stale-issue

Comments

@cevich
Copy link
Member

cevich commented Feb 19, 2024

Issue Description

In CI, linting on the osx_alt_build_task task is disabled.

Steps to reproduce the issue

Steps to reproduce the issue

  1. Open a PR

Describe the results you received

Task runs make lint || true

Describe the results you expected

Task runs make lint and returns a zero exit-code.

podman info output

N/A

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

N/A

Additional information

N/A

@cevich cevich added the kind/bug Categorizes issue or PR as related to a bug. label Feb 19, 2024
@mheon
Copy link
Member

mheon commented Feb 19, 2024

Fix in #21753

Copy link

A friendly reminder that this issue had no activity for 30 days.

@mheon
Copy link
Member

mheon commented Mar 21, 2024

This is done

@mheon mheon closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. stale-issue
Projects
None yet
Development

No branches or pull requests

2 participants