Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurations section for podmansh #22767

Closed
grisu48 opened this issue May 21, 2024 · 3 comments
Closed

Add configurations section for podmansh #22767

grisu48 opened this issue May 21, 2024 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@grisu48
Copy link
Contributor

grisu48 commented May 21, 2024

Feature request description

Currently podmansh is using the hard-coded /bin/sh shell, however there are use cases where people might want to have a different shell.

A possible solution would be to link /bin/sh to the desired user shell, e.g. /bin/fish but that would likely break a good portion of shell scripts that require or use #!/bin/sh. Therefore the configuration of at least the shell for podmansh would make sense.

Suggest potential solution

Introduce a new podmansh section in containers.conf that allows users to configure the various parameters used by podmansh:

  • Shell
  • Container name
  • Timeout

Have you considered any alternatives?

I tried to use environment variables but that appeared a bit clumsy to me.
I also tried to use container labels but they are not user-configurable options.

A new configuration section allows users to set their preferred shell via ~/.config/containers/containers.conf.

Additional context

No response

@grisu48 grisu48 added the kind/feature Categorizes issue or PR as related to a new feature. label May 21, 2024
@grisu48
Copy link
Contributor Author

grisu48 commented May 21, 2024

I've created this issue to track this feature based on my suggestions in containers/common#1993 and #22683

Please feel free to assign it to me directly.

@grisu48
Copy link
Contributor Author

grisu48 commented May 23, 2024

containers/common#1993 and #22683 are merged.

@grisu48
Copy link
Contributor Author

grisu48 commented May 23, 2024

Task completed, I would recommend to add a 5.1 label to it now and close it.

@Luap99 Luap99 closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants