Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write configuration in ~/.config/containers; only read them #4214

Closed
debarshiray opened this issue Oct 7, 2019 · 4 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@debarshiray
Copy link
Member

/kind bug

Description

One of the bigger pain points of the Cgroups v2 migration was the presence of runtime="runc" in ~/.config/containers/libpod.conf. In the past we had a bug where ~/.config/containers/storage.conf could get corrupted, creating all sorts of confusion.

Dumping default values into configuration files in $HOME locks the user into a specific software version. There's no clean way to update the defaults along with the software because operating system updates are not meant to touch $HOME.

If we do want to create these files as guidelines for users, then everything should be commented out, as if the file doesn't exist; but then we have to maintain code that writes the files, as opposed to just reading them. It seems easier to just let humans do the writing, and document it in a manual.

Ideally all the defaults should be embedded in code, and it should be able to work without any configuration at all on a sanely set up environment. If we ship any configuration, to aid the code because it cannot auto-detect something or as vendor configuration, then it should only be in one of the OS-controlled locations. Ideally, this should be in /usr (eg., /usr/share/zoneinfo, /usr/lib/sysctl.d, etc.) but the current /etc/containers is fine for the purpose of this issue.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2019
@debarshiray debarshiray changed the title Don't write configuration files in ~/.config/containers; only read them Don't write configuration in ~/.config/containers; only read them Oct 7, 2019
@mheon
Copy link
Member

mheon commented Oct 17, 2019

@vrothberg is looking into rewriting our configuration-handling logic to allow this.

Current thinking is that we will still write a config file, but it will only contain paths for c/storage and Libpod; everything else will be sourced from the root defaults.

@QuLogic
Copy link

QuLogic commented Oct 19, 2019

This looks a bit like #3658.

@mheon
Copy link
Member

mheon commented Nov 1, 2019

@vrothberg I think your latest PR fixes this?

@vrothberg
Copy link
Member

Yes, Podman is not auto-generating it anymore.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

5 participants