Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --filter flag in podman image prune #4411

Closed
XVilka opened this issue Nov 1, 2019 · 3 comments · Fixed by #4512
Closed

Support --filter flag in podman image prune #4411

XVilka opened this issue Nov 1, 2019 · 3 comments · Fixed by #4512
Assignees
@kunalkushwaha
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@XVilka
Copy link

XVilka commented Nov 1, 2019

/kind feature

Description

Docker CLI has a --filter flag for the docker image prune command. So for podman to be compatible with docker, especially in scripts, at least it would be better not to show an error:

Steps to reproduce the issue:

  1. podman image prune --filter "until=12h"

Describe the results you received:

Error: unknown flag: --filter

Describe the results you expected:

Should not throw an error on --filter, moreover, it should support specifying the flag multiple times, and it should support filtering itself.
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 1, 2019
@XVilka XVilka mentioned this issue Nov 1, 2019
Closed
@rhatdan
Copy link
Member

rhatdan commented Nov 1, 2019

@XVilka Interested in opening a PR?

@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Nov 1, 2019
@XVilka
Copy link
Author

XVilka commented Nov 4, 2019

Sorry, I don't have much experience with Go.

@kunalkushwaha
Copy link
Collaborator

I am also facing this issue.. will pick it up.

/assign

@kunalkushwaha kunalkushwaha mentioned this issue Nov 15, 2019
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kunalkushwaha kunalkushwaha

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

image prune command fixed as per docker image prune. kunalkushwaha/libpod
4 participants
@XVilka @rhatdan @kunalkushwaha @openshift-ci-robot