Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The checks in hack/ directory hardcode `cc' #2278

Closed
graywolf opened this issue Mar 31, 2024 · 4 comments · Fixed by #2322
Closed

The checks in hack/ directory hardcode `cc' #2278

graywolf opened this issue Mar 31, 2024 · 4 comments · Fixed by #2322
Labels
kind/feature A request for, or a PR adding, new functionality

Comments

@graywolf
Copy link
Contributor

graywolf commented Mar 31, 2024

The scripts in the hack/ directory assume that cc' binary is present in the build environment. That might not always be the case (the C compiler might be present as gcc' for example). Podman project does https://github.com/containers/podman/blob/main/hack/btrfs_tag.sh#L2 , would be nice if skopeo started to do the same.

@rhatdan
Copy link
Member

rhatdan commented Apr 2, 2024

Interested in making a PR to add support?

@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Apr 2, 2024
@graywolf
Copy link
Contributor Author

graywolf commented Apr 3, 2024

Sure, will do.

Copy link

github-actions bot commented May 4, 2024

A friendly reminder that this issue had no activity for 30 days.

@graywolf
Copy link
Contributor Author

graywolf commented May 4, 2024

A friendly reminder that this issue had no activity for 30 days.

Yeah yeah I know. Will get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants