Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer builds on OSX #310

Closed
so0k opened this issue Feb 21, 2017 · 6 comments
Closed

No longer builds on OSX #310

so0k opened this issue Feb 21, 2017 · 6 comments

Comments

@so0k
Copy link
Contributor

so0k commented Feb 21, 2017

$ make binary-local
go build -ldflags "-X main.gitCommit=b08008c5b21ec869f40f8eb2a6f2e8687984bf95" -gcflags "" -tags "btrfs_noversion libdm_no_deferred_remove" -o skopeo ./cmd/skopeo
# github.com/projectatomic/skopeo/vendor/github.com/containers/storage/storage
vendor/github.com/containers/storage/storage/lockfile.go:136: st.Mtim undefined (type syscall.Stat_t has no field or method Mtim)
vendor/github.com/containers/storage/storage/lockfile.go:136: not enough arguments in call to time.Unix
make: *** [binary-local] Error 2

My fork from Oct 21, 2016 still works

git clone git@github.com:so0k/skopeo.git
git checkout add-osx-instructions
brew install gpgme
make binary-local
@mtrmac
Copy link
Collaborator

mtrmac commented Feb 21, 2017

Thanks for your report.

@nalind , any idea?

@nalind
Copy link
Member

nalind commented Feb 21, 2017

This looks like something containers/storage#11 aims to fix. @so0k any chance you can try pulling that branch (I've just rebased it) into your checkout and seeing if that helps? The storage package should be fine, but I don't have the other native libraries wants to link against here, so I can't say 100% that it'll resolve this.

@huntc
Copy link

huntc commented Mar 1, 2017

Unfortunately the same for me - any progress? Thanks.

@so0k
Copy link
Contributor Author

so0k commented Mar 1, 2017

I'm using my fork for now, didn't have time to try out the suggested fix yet

@mtrmac
Copy link
Collaborator

mtrmac commented Apr 28, 2017

containers/storage#11 has now been merged upstream.

macOS users, please test whether #331 makes it possible to build skopeo again.

@mtrmac
Copy link
Collaborator

mtrmac commented May 12, 2017

Per containers/image#268 (comment) , assuming that #331 has fixed this; if not, please do reopen this issue or file a new one for the new build failures.

@mtrmac mtrmac closed this as completed May 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants