Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master failed to build in container due to golang version is 1.8 #587

Closed
rockmenjack opened this issue Jan 9, 2019 · 5 comments
Closed

Comments

@rockmenjack
Copy link

docker run --rm --security-opt label=disable -v $(pwd):/src/github.com/containers/skopeo \
        skopeobuildimage make binary-local  BUILDTAGS='   containers_image_ostree_stub '
go build "-buildmode=pie" -ldflags "-X main.gitCommit=17bea86e89730eacf24b985d0125e47ac0000542" -gcflags "" -tags "containers_image_ostree_stub " -o skopeo ./cmd/skopeo
vendor/github.com/klauspost/compress/flate/inflate.go:13:2: cannot find package "math/bits" in any of:
        /src/github.com/containers/skopeo/vendor/math/bits (vendor tree)
        /usr/lib/go-1.8/src/math/bits (from $GOROOT)
        /src/math/bits (from $GOPATH)

math/bits was introduced since go 1.9

@chengyli
Copy link

why not merging this commit?
85d26de

@vrothberg
Copy link
Member

Thanks for the ping. Once #575 is rebased, we can merge it.

@reenberg
Copy link

Wow, terrible user experience out of the box, especially considering #594 and when you are not running fedora.

Building in a container doesn't seem to have worked since v0.1.32, from Nov 7 2018.
This Issue was opened Jan 9 and #575 is from Dec 16 2018 as well... Please fix this simple thing.

@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

@reenberg PRs welcome.

@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

Since the PR is merged, I will close the issue.

@rhatdan rhatdan closed this as completed Apr 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants