Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/system: Fix flaky test #844

Merged

Conversation

HarryMichal
Copy link
Member

@HarryMichal HarryMichal commented Jul 16, 2021

This is a naive attempt to solve the flaking. It could be caused by what
is going inside of the run function.

Supersedes #705

@HarryMichal HarryMichal added 6. Minor Change Should not cause breakage 3. Bugfix Fixes a bug 2. Testing Related to testing of Toolbox - unit, system,.. labels Jul 16, 2021
@HarryMichal HarryMichal added this to the Release 0.1.0 milestone Jul 16, 2021
@HarryMichal HarryMichal force-pushed the test/system/fix-flaky-sudo-test branch from 5d8b081 to 292701b Compare July 16, 2021 19:03
@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal HarryMichal force-pushed the test/system/fix-flaky-sudo-test branch from 292701b to 5f855c4 Compare July 21, 2021 16:31
@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal HarryMichal force-pushed the test/system/fix-flaky-sudo-test branch from 5f855c4 to ff7ec76 Compare July 21, 2021 22:06
@softwarefactory-project-zuul
Copy link

Build failed.

This is a naive attempt to solve the flaking. It could be caused by what
is going inside of the run function.
@HarryMichal HarryMichal force-pushed the test/system/fix-flaky-sudo-test branch from ff7ec76 to 5e68832 Compare July 21, 2021 22:49
@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@HarryMichal
Copy link
Member Author

I have a good feeling about this fix.

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal HarryMichal merged commit b0beb68 into containers:main Jul 22, 2021
@HarryMichal HarryMichal deleted the test/system/fix-flaky-sudo-test branch July 22, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. Testing Related to testing of Toolbox - unit, system,.. 3. Bugfix Fixes a bug 6. Minor Change Should not cause breakage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant