New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/system: Fix flaky test #844
Merged
HarryMichal
merged 1 commit into
containers:main
from
HarryMichal:test/system/fix-flaky-sudo-test
Jul 22, 2021
Merged
test/system: Fix flaky test #844
HarryMichal
merged 1 commit into
containers:main
from
HarryMichal:test/system/fix-flaky-sudo-test
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
6. Minor Change
Should not cause breakage
3. Bugfix
Fixes a bug
2. Testing
Related to testing of Toolbox - unit, system,..
labels
Jul 16, 2021
HarryMichal
force-pushed
the
test/system/fix-flaky-sudo-test
branch
from
July 16, 2021 19:03
5d8b081
to
292701b
Compare
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build failed.
|
recheck |
Build failed.
|
recheck |
Build failed.
|
recheck |
Build failed.
|
recheck |
Build failed.
|
HarryMichal
force-pushed
the
test/system/fix-flaky-sudo-test
branch
from
July 21, 2021 16:31
292701b
to
5f855c4
Compare
Build succeeded.
|
HarryMichal
force-pushed
the
test/system/fix-flaky-sudo-test
branch
from
July 21, 2021 22:06
5f855c4
to
ff7ec76
Compare
Build failed.
|
This is a naive attempt to solve the flaking. It could be caused by what is going inside of the run function.
HarryMichal
force-pushed
the
test/system/fix-flaky-sudo-test
branch
from
July 21, 2021 22:49
ff7ec76
to
5e68832
Compare
Build succeeded.
|
recheck |
I have a good feeling about this fix. |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. Testing
Related to testing of Toolbox - unit, system,..
3. Bugfix
Fixes a bug
6. Minor Change
Should not cause breakage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive attempt to solve the flaking. It could be caused by what
is going inside of the run function.
Supersedes #705