Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare Vagrant instead of devcontainer for platforms other than linux. #100

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jun 19, 2021

Use vagrant because container in container is difficult for security reasons.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jun 20, 2021

Hey, I think it would be good idea to include information that something like virtualbox needs to be also installed for vagrant to work, I was trying to test this on linux, and at least on it, vagrant needs virtualbox already installed.

That said, this is meant for non-linux OSs so someone running such OSs might give a better opinion.

@utam0k
Copy link
Member Author

utam0k commented Jun 21, 2021

@YJDoc2 I wasn't sure if I should include it in the README, but I didn't think it was necessary to support it in the README. Do you think about?

Vagrantfile Outdated

Vagrant.configure("2") do |config|
config.vm.box = "fedora/33-cloud-base"
config.vm.provider :virtualbox do |v|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows Hyper-V is the most likely virtualization solution to be available

@tsturzl
Copy link
Collaborator

tsturzl commented Jun 24, 2021

I had worked on something similar, mostly with the intention of addressing #39. I found that it was difficult to get the integration tests working in these VMs. Often times the swap accounting features were disabled in the kernel which causes the runtime-tools to outright fail even when testing runc. I hadn't figured out a way to address this yet without doing a lot of setup steps to modify kernel boot params, which quickly became cumbersome. I had fooled around on this branch: https://github.com/tsturzl/youki/tree/ts-multi-system-testing

I ultimately put this work aside awaiting a response on opencontainers/runtime-tools#721

Vagrantfile Show resolved Hide resolved
@utam0k
Copy link
Member Author

utam0k commented Jul 4, 2021

@tsturzl @Furisto @YJDoc2 PTAL

@utam0k
Copy link
Member Author

utam0k commented Jul 4, 2021

I had worked on something similar, mostly with the intention of addressing #39. I found that it was difficult to get the integration tests working in these VMs. Often times the swap accounting features were disabled in the kernel which causes the runtime-tools to outright fail even when testing runc. I hadn't figured out a way to address this yet without doing a lot of setup steps to modify kernel boot params, which quickly became cumbersome. I had fooled around on this branch: https://github.com/tsturzl/youki/tree/ts-multi-system-testing

I ultimately put this work aside awaiting a response on opencontainers/runtime-tools#721

I have seen your branch. It is great. It would be better if runtime-tools could solve this problem, but they don't seem to be very active. I guess we'll just have to deal with it on youki side.

@utam0k utam0k merged commit 90dd96c into containers:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants