distinguish channels more clearly between each process #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuaf
reviewed
Aug 30, 2021
src/process/channel.rs
Outdated
| impl SenderExt for Sender { | ||
| #[inline] | ||
| fn write_message(&mut self, msg: Message) -> Result<()> { | ||
| self.write_all(&(msg as u8).to_be_bytes())?; |
There was a problem hiding this comment.
Can we add error context here for error msg?
| } | ||
|
|
||
| pub fn intermediate_to_main() -> Result<(SenderIntermediateToMain, ReceiverFromIntermediate)> { | ||
| let (sender, receiver) = new_pipe()?; |
There was a problem hiding this comment.
Isn't new_pipe already has this part of the code?
There was a problem hiding this comment.
I might as well have been asleep.
| sender: Sender, | ||
| } | ||
|
|
||
| impl SenderInitToIntermediate { |
There was a problem hiding this comment.
Since we differentiate channel here, the init process don't ready send pid to the intermediate process, so the init_ready here don't have to send Pid. In the init process, since it is already inside the pid namespace, it doesn't know what is the real pid outside the pid namespace. The intermediate process knows the pid anyway since it is one doing the fork.
|
@yihuaf PTAL |
yihuaf
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.