Name the test tools contest
#2486
Conversation
utam0k
force-pushed
the
contest
branch
4 times, most recently
from
85d8cd5
to
7b0201d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
=======================================
Coverage 65.88% 65.88%
=======================================
Files 133 133
Lines 16819 16819
=======================================
Hits 11081 11081
Misses 5738 5738 |
utam0k
force-pushed
the
contest
branch
2 times, most recently
from
cd58f34
to
738c108
Compare
utam0k
force-pushed
the
contest
branch
11 times, most recently
from
96c06a8
to
3f38212
Compare
Signed-off-by: utam0k <k0ma@utam0k.jp>
|
Hey, I'll take a look at this around the weekend. In the meantime, May I ask you to check if we need any changes in our documentation for this? |
There was a problem hiding this comment.
I feel moving the test_framework outside the contest, i.e. under the path tests/test_framework would be better, as then we can re-use it for other tests such as podman rootless and wasm tests when we add them.
@utam0k Overall looks nice, just have few comments, please take a look at them.
|
@utam0k 👀 |
|
Sorry I don't find out the time to address it 🙏 |
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
|
@utam0k , overall looks ok, but can you take a look at the remaining comments above when you get time? Thanks! |
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
|
@YJDoc2 Thanks for your quick review 🙏 Is there anything I can address? |
Until now our testing tools have not had names, but we will give them names to make them easier to understand.