Specify the protobuf crate because of the rust-criu crate #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: utam0k <k0ma@utam0k.jp>
|
Hey @utam0k is there anything urgent blocking on this? I think this dependency bug should be handled in upstream itself, rather than we adding the constraint here. I'll approve this PR in case something urgently needs this patch in youki, but otherwise I think we should wait for the crate itself to fix it properly. |
YJDoc2
approved these changes
Nov 2, 2023
Thanks for your review. We can't build youki from scratch at lease in my environment 😭 |
This was referenced Dec 17, 2023
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround: checkpoint-restore/rust-criu#19