Re enable skipped e2e tests #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
=======================================
Coverage 65.50% 65.50%
=======================================
Files 133 133
Lines 16916 16916
=======================================
Hits 11081 11081
Misses 5835 5835 |
utam0k
reviewed
Jan 22, 2024
Comment on lines
51
to
54
| Box::new(|| match std::env::var("RUNTIME_KIND") { | ||
| Err(_) => true, | ||
| Ok(s) => s != "runc", | ||
| }), |
There was a problem hiding this comment.
How about turn into a function and putting others together?
There was a problem hiding this comment.
There was a problem hiding this comment.
Done, please take a look!
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
YJDoc2
force-pushed
the
fix/enable-blocked-e2e
branch
from
1451e3a
to
b0a4457
Compare
utam0k
approved these changes
Jan 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2616
There are some tests which are (for now) only supported by youki, and not by the latest release of runc. Instead of not running those tests, we instead check an env var to see what runtime we are running, and skip those for runc.