Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) podman e2e : Update workflow for new required deps, add vagrantfile #2687

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Feb 17, 2024

With some recent changes in how podman repo runs its e2e, and deps that are needed by latest main branch, our podman e2e CI are failing all its tests due to missing deps from about a week.

This PR updates the CI to include the missing deps, and also adds a vagrant file that allows running those tests locally without having to change host system, like we have for containerd e2e.

Someone please also verify that vagrantfile works , as even though I have tested it, I had run it iteratively, so could have possibly missed some changes that I did manually. As long as the VAGRANT_VAGRANTFILE=Vagrantfile.podmane2e vagrant up command runs without any error, it should be ok. Note that the go download is expected to take some time, so there would not be any logs while that is running due to --quiet flag.

Thanks!

EDIT : I ran the podman e2e on this branch in my repo, and it shows the same number of failed test, as there were before all tests started failing : https://github.com/YJDoc2/youki/actions/runs/7942453846

@YJDoc2 YJDoc2 requested a review from a team February 17, 2024 15:35
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

Merging #2687 (67ecda6) into main (762a2e8) will increase coverage by 0.00%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2687   +/-   ##
=======================================
  Coverage   65.40%   65.41%           
=======================================
  Files         133      133           
  Lines       16942    16942           
=======================================
+ Hits        11081    11082    +1     
+ Misses       5861     5860    -1     

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Feb 20, 2024

@lengrongfu may I ask you to take a look at this?

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for me, it looks good. But we have to wait for @lengrongfu's review.

Copy link
Collaborator

@lengrongfu lengrongfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running VAGRANT_VAGRANTFILE=Vagrantfile.podmane2e vagrant up on ubuntu22.04 passed.

LGTM

@YJDoc2 YJDoc2 merged commit 0c068b8 into containers:main Feb 20, 2024
28 checks passed
@YJDoc2 YJDoc2 deleted the fix/podman_e2e branch February 20, 2024 15:35
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants