Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Remove GitPod and add link to GitHub codespaces #2717

Merged
merged 1 commit into from
Mar 6, 2024
Merged

📝 Remove GitPod and add link to GitHub codespaces #2717

merged 1 commit into from
Mar 6, 2024

Conversation

homersimpsons
Copy link
Contributor

Fixes #2678

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 1, 2024

Thanks for opening the PR!
May I ask you to sign off your commit : https://github.com/containers/youki/pull/2717/checks?check_run_id=22180998348

Fixes #2678

Signed-off-by: homersimpsons <guillaume.alabre@gmail.com>
@homersimpsons
Copy link
Contributor Author

May I ask you to sign off your commit : https://github.com/containers/youki/pull/2717/checks?check_run_id=22180998348

Done ✅

@homersimpsons
Copy link
Contributor Author

homersimpsons commented Mar 2, 2024

There are 2 failures:

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 3, 2024
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 6, 2024

Thanks @homersimpsons !

I'll go ahead and merge it, as there are no code changes, and the pending CI checks are for tests etc.

@YJDoc2 YJDoc2 merged commit 84addaf into containers:main Mar 6, 2024
24 of 25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitPod fails
3 participants