Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Code Coverage Fix #273

Merged
merged 3 commits into from
Sep 6, 2021
Merged

CI Code Coverage Fix #273

merged 3 commits into from
Sep 6, 2021

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Sep 6, 2021

ref #226 #272
This attempts to Fix code coverage issue :
After seeing actions-rs/grcov#105, which asks to update code coverage using inbuilt features of llvm, as well as PyO3 also seems to use it, (which is quite a big lib). So I tried to use similar workflow as https://github.com/PyO3/pyo3/blob/main/.github/workflows/ci.yml to see if it can fix the issue.

@codecov-commenter
Copy link

Codecov Report

Merging #273 (a01be9d) into main (b8442af) will increase coverage by 28.70%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #273       +/-   ##
===========================================
+ Coverage   41.22%   69.92%   +28.70%     
===========================================
  Files          15       46       +31     
  Lines        1458     5693     +4235     
  Branches      412        0      -412     
===========================================
+ Hits          601     3981     +3380     
- Misses        645     1712     +1067     
+ Partials      212        0      -212     

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Sep 6, 2021

So I think this does work for accounting code coverage in cgroups as well. On codecov docs, it states that reports are merged : https://docs.codecov.com/docs/merging-reports So I think this merges the code coverage for youki as well as cgroups both.

On another node, this didn't spawn format and clippy jobs as no code was changed, which means the check job is working as expected !!! 🎉 🎉 🎉

@utam0k please take a look once, and verify.

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Sep 6, 2021

I also think the grcov.yaml file is not needed anymore and can be deleted, but not sure.

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Sep 6, 2021

Also, I just came around https://github.com/Swatinem/rust-cache, should we try changing our plain cache action with this one specifically for rust?

Update : I think we should take a look at https://matklad.github.io/2021/09/04/fast-rust-builds.html as well, seems really useful.

@utam0k
Copy link
Member

utam0k commented Sep 6, 2021

Let's install it and measure the benchmarks!

Also, I just came around https://github.com/Swatinem/rust-cache, should we try changing our plain cache action with this one specifically for rust?

@utam0k utam0k merged commit 5a429e1 into containers:main Sep 6, 2021
@YJDoc2 YJDoc2 deleted the ci_ccov_fix branch September 25, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants