Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.77.1 #2746

Merged
merged 2 commits into from Apr 10, 2024
Merged

Rust 1.77.1 #2746

merged 2 commits into from Apr 10, 2024

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Apr 7, 2024

No description provided.

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 7, 2024
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k marked this pull request as ready for review April 8, 2024 10:52
@utam0k utam0k requested a review from a team April 8, 2024 10:52
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, otherwise looks ok, but in two files crates/libcgroups/src/lib.rs and tests/contest/contest/src/utils/mod.rs I don't think unused_imports is required? I tried removing them, and for the first file, it worked, and for second, I needed to remove the unused imports, which I think is better.

wdyt?

@utam0k
Copy link
Member Author

utam0k commented Apr 8, 2024

Hey, otherwise looks ok, but in two files crates/libcgroups/src/lib.rs and tests/contest/contest/src/utils/mod.rs I don't think unused_imports is required? I tried removing them, and for the first file, it worked, and for second, I needed to remove the unused imports, which I think is better.

wdyt?

Thanks for your check. Did you pass all CI?

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Apr 10, 2024

For crates/libcgroups/src/lib.rs we need it due to feature test, but I managed to pass CI with removing the extra imports in tests/contest/contest/src/utils/mod.rs. I'll push another commit removing this and merge the PR.

Thanks!

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
@YJDoc2 YJDoc2 merged commit a48e5a5 into containers:main Apr 10, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants