update wasmtime dep to 19.0.1, replace wasmtime-wasi with wasi-common #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
YJDoc2
added
the
kind/cleanup
This was referenced Apr 10, 2024
YJDoc2
changed the title
yihuaf
approved these changes
Apr 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the wasmtime dep to 19.0.1. The functions that we use from wasmtime-wasi were deprecated from that crate, and instead moved to wasi-common crate, see deprecation notice on 18.0.3 here . Thus replaced wasmtime-wasi with wasi-common.
This replaces dependabot PRs #2735 and #2750 .
I also request the reviewer to actually run a wasm container using wasi on this branch and validate it works, as we still don't have enough testing around wasm.