Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial progress on supporting OwnedFd #2809

Merged
merged 2 commits into from
Jul 23, 2024
Merged

initial progress on supporting OwnedFd #2809

merged 2 commits into from
Jul 23, 2024

Conversation

zahash
Copy link
Contributor

@zahash zahash commented Jun 5, 2024 •
edited
Loading

related to issue #2417

@zahash zahash mentioned this pull request Jun 5, 2024
Open
@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 5, 2024
utam0k
utam0k requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zahash Please elaborate a bit more 🙏

@zahash
Copy link
Contributor Author

zahash commented Jun 8, 2024

@utam0k Sorry i think i linked the wrong issue. I changed it to the correct one just now.

also, a lot of explanation was done in the issue comments

@utam0k
Copy link
Member

utam0k commented Jun 16, 2024 •
edited
Loading

@zahash Thanks for your update, but there isn't enough information to start a review. Apparently, the title of the PR is wrong.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jul 11, 2024

@zahash ping!

@zahash zahash changed the title fix 2417 initial progress on supporting OwnedFd Jul 15, 2024
@zahash
Copy link
Contributor Author

zahash commented Jul 15, 2024

@utam0k @YJDoc2

i have changed the title.
the idea is, OwnedFd cannot be cloned. so before switching to OwnedFd, we have to make sure no cloning is done.
the next step would be to use OwnedFd inside sender and reciever instead of RawFd

@utam0k
Copy link
Member

utam0k commented Jul 23, 2024

💯

the idea is, OwnedFd cannot be cloned. so before switching to OwnedFd, we have to make sure no cloning is done.

@utam0k utam0k merged commit 1615b17 into containers:main Jul 23, 2024
27 of 28 checks passed
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zahash @utam0k @YJDoc2