Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates #2829

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Add issue templates #2829

merged 2 commits into from
Jul 12, 2024

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Jun 23, 2024

This adds Bug report and Feature request issue templates.

@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 23, 2024
@YJDoc2 YJDoc2 requested a review from a team June 23, 2024 10:20
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 10 to 30
**Bug Description**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**System Info**
Add information about your system. If Youki is compiling and running on your system, please add o/p of `youki info` .

**Setup Info**
If you are experiencing issues in compiling Youki, or related deps, please add details regarding your setup, dependencies etc. Also if you are running Youki via something else (Docker, podman, k8s) add its info here.

**Additional context**
Add any other context about the problem here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to have all this information to create an issue? I feel that it'd be a waste to miss the opportunity to have an issue created at this stage of the phase. But, it might be useful to have labels and so on.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that it'd be a waste to miss the opportunity to have an issue created at this stage of the phase

I'm not sure what you mean here 😅

As for the details, I think we can also add an empty issue template, which will not have any fields, and behave similar to how current 'new issue' works. I agree that having to add this much info can be troublesome, but I feel having these details would be good for understanding and debugging the issues.

Copy link
Member

@utam0k utam0k Jun 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, let me tell you more details.

but I feel having these details would be good for understanding and debugging the issues.

Yes, this helps us understand the issue. However, how about an issue's author? Perhaps filling in some fields is tedious, and they may stop making issues. I'm worried about it.
But, if we use the issue form, we can mark require or not require in each issue form's section. We use it in order to solve this problem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, yep I get it now. That is a valid concern. I'll update the PR to use forms instead.

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Jun 29, 2024

May I ask you to use issue forms instead of *.md?

Sure, I had not used them as they are in beta stage, and can potentially change, but after the above comment is discussed, I'll change this for forms.

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Jul 11, 2024

@utam0k I have changed to forms now. I have made only a couple of fields as required, others are optional. Please take a look.

@@ -0,0 +1 @@
blank_issues_enabled: true # allow people to not use forms, just directly create issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this option 👀

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks

@utam0k
Copy link
Member

utam0k commented Jul 12, 2024

YJDoc2 and others added 2 commits July 12, 2024 18:27
This adds Bug report and Feature request issue templates.

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
@YJDoc2 YJDoc2 force-pushed the cleanup/add_issue_templates branch from b4d654b to 2244bda Compare July 12, 2024 12:57
@YJDoc2 YJDoc2 enabled auto-merge (squash) July 12, 2024 12:58
@YJDoc2 YJDoc2 merged commit 1f90ff2 into main Jul 12, 2024
28 checks passed
@YJDoc2 YJDoc2 deleted the cleanup/add_issue_templates branch July 12, 2024 13:05
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants