Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved needs_to_handle TODO's #568

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Conversation

SarthakSingh31
Copy link
Contributor

The compiler error mentioned in the TODO doesn't occur in any version of rust that can use the 2021 edition.
Ran cargo test on the following versions without getting any errors:

  • 1.56.0
  • 1.56.1
  • 1.57.0
  • 1.58.0-beta.2 (0e07bcb68 2021-12-04)
  • 1.59.0-nightly (51e8031e1 2021-12-25)

@codecov-commenter
Copy link

Codecov Report

Merging #568 (bb4b398) into main (91b7632) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   61.15%   60.64%   -0.52%     
==========================================
  Files          85       99      +14     
  Lines       12564    12667     +103     
==========================================
- Hits         7684     7682       -2     
- Misses       4880     4985     +105     

@Furisto
Copy link
Member

Furisto commented Dec 27, 2021

@SarthakSingh31 Thanks!

@Furisto Furisto merged commit 91fc298 into containers:main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants