Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore autogenerated code #592

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Jan 4, 2022

This excludes the code that has been auto generated for seccomp and dbus from code coverage.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #592 (ac7c16a) into main (de6385f) will increase coverage by 9.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   61.18%   70.18%   +9.00%     
==========================================
  Files          85       82       -3     
  Lines       12553    10909    -1644     
==========================================
- Hits         7681     7657      -24     
+ Misses       4872     3252    -1620     

Copy link
Collaborator

@tsturzl tsturzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this not be done by ignoring via the .codecov.yml?

@Furisto Furisto force-pushed the exclude-autogenerated branch 2 times, most recently from bdbb780 to 55ee127 Compare January 4, 2022 18:03
@Furisto
Copy link
Member Author

Furisto commented Jan 4, 2022

@tsturzl Does not look that way. Direct vs Yaml

@tsturzl
Copy link
Collaborator

tsturzl commented Jan 4, 2022

@Furisto Good catch, could you possibly add the integration tests to this as well?

@Furisto
Copy link
Member Author

Furisto commented Jan 4, 2022

@tsturzl Done

Copy link
Collaborator

@tsturzl tsturzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsturzl tsturzl merged commit f378fd0 into containers:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants