Allow multiple rules from docker labels containers with traefik.<servicename>.* properties #1257

benoitf · 2017-03-08T14:19:50Z

It matches expectation of #444
If labels contain for example:

traefik.mycustomservice.port=443
traefik.mycustomservice.frontend.rule=Path:/mycustomservice
traefik.anothercustomservice.port=8080
traefik.anothercustomservice.frontend.rule=Path:/anotherservice

all traffic to frontend on path /mycustomservice is redirected to the port 443 of the container defining the label while using path /anotherservice will redirect to the port 8080 of the docker container defining the label

Available properties are
traefik.<service-name>.port
traefik.<service-name>.weight
traefik.<service-name>.protocol
traefik.<service-name>.frontend.backend
traefik.<service-name>.frontend.entryPoints
traefik.<service-name>.frontend.rule
traefik.<service-name>.frontend.passHostHeader
traefik.<service-name>.frontend.priority
traefik.<service-name>.frontend.rule

More documentation in the docs/toml.md file
new tests added to docker_tests.go

Change-Id: Ifaa3bb00ef0a0f38aa189e0ca1586fde8c5ed862
Signed-off-by: Florent BENOIT fbenoit@codenvy.com

vdemeester

Looks really good, just one small comment 👼

vdemeester · 2017-03-10T15:15:31Z

provider/docker.go

+
+// Extract entrypoints from labels for a given service and a given docker container
+func (provider *Docker) getServiceEntryPoints(container dockerData, serviceName string) []string {
+	if entryPoints, ok := extractServicesLabels(container.Labels)[serviceName]["frontend.entryPoints"]; ok {


Not a huge fan of that notation ; would have prefered to pass serviceName and the key (here frontend.entryPoints) as arguments (and thus make it sure these function don't care how the label are extracted, using maps or something else).

ok so you prefer something more generic ?
getServiceValue $container $serviceName $key ?

yeah, I don't want to surface the fact that this is a map or something else 👼

if entryPoints, ok := getContainerServiceLabel(container, serviceName, "frontend.entryPoints")

looks of for you ?

looks perfect to me 👼 👍

I've updated to call getContainerServiceLabel (this new function is delegating to extractServicesLabels)
Let me know if it's ok or if you want to remove as well the intermediate extractServicesLabels

vdemeester · 2017-03-10T15:16:39Z

provider/docker_test.go

@@ -2271,3 +2271,613 @@ func TestSwarmTaskParsing(t *testing.T) {
 		}
 	}
 }
+
+func TestDockerGetServiceProtocol(t *testing.T) {


I'll have to work on these, because our unit tests are way too verbose (but it's orthogonal to this PR, just thinking outloud 🤔 ).

ah for sure they are verbose ^^

benoitf · 2017-03-10T16:32:22Z

updated

benoitf · 2017-03-11T07:51:55Z

@intelradoux you can use Host in the front-end rule. So AFAIK this is possible with this PR
You define two services with two different Host front-end rule

vdemeester

LGTM 🐯

emilevauge

@benoitf Really good job 😍
LGTM
Could you squash your commits before we merge it ?

benoitf · 2017-03-13T18:52:32Z

@emilevauge ok done

- traefik.mycustomservice.port=443 - traefik.mycustomservice.frontend.rule=Path:/mycustomservice - traefik.anothercustomservice.port=8080 - traefik.anothercustomservice.frontend.rule=Path:/anotherservice all traffic to frontend /mycustomservice is redirected to the port 443 of the container while using /anotherservice will redirect to the port 8080 of the docker container More documentation in the docs/toml.md file Change-Id: Ifaa3bb00ef0a0f38aa189e0ca1586fde8c5ed862 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>

timoreimann · 2017-03-14T09:32:46Z

Merci, @benoitf! Merged. 😃

benoitf · 2017-03-14T10:28:57Z

thx. So it won't be in 1.2 ?

vdemeester · 2017-03-14T10:32:53Z

@benoitf yeah, putting this in 1.3 milestone. 1.2 is already freezed so… 👼 😅

benoitf · 2017-03-14T10:40:53Z

ok :)

dcrystalj · 2017-03-21T09:40:11Z

I am testing your PR now.

I created simple service as

    docker service create \
    --name=visualizer \
    --network=proxy \
    --constraint=node.role==manager \
    --mount=type=bind,src=/var/run/docker.sock,dst=/var/run/docker.sock \
    --label traefik.visualizer.port=8080 \
    --label traefik.visualizer.network=proxy \
    --label traefik.visualizer.frontend.rule=Host:visualizer.traefik \
    --label traefik.visualizer.frontend.entryPoints=http,https \
    manomarks/visualizer:latest

While putting old school traefik.port is working this .visualizer. as <service-name> does not. In traefik gui on port 8080 this service is not shown.

I am running image containous/traefik:experimental

timoreimann · 2017-03-21T09:45:32Z

@dcrystalj if you run into problems, please create a new issue and / or get in touch with the Traefik community on Slack.

Thanks!

alwaysastudent · 2017-04-03T00:07:40Z

@benoitf - Does this support multiple services if they reside on same port ? What if I want to hit two different paths based on the Host header ?

Thanks to Traefik 1.3 now we can use only traefik for separating normal Odoo requests from longpolling ones. See traefik/traefik#1257.

reflog · 2018-02-26T08:12:20Z

Hi! Any chance to get this working on ECS backend?

ldez · 2018-02-26T08:59:58Z

@reflog yes it's in my todo list.

reflog · 2018-02-26T09:03:38Z

@ldez - that's awesome! Is there any way to simulate this behavior right now? I am trying add these two rules (they worked in docker):

      - "traefik.test.frontend.rule=Host:whoami.docker.localhost;Path:/;ReplacePath:/api"
      - "traefik.test2.frontend.rule=Host:whoami.docker.localhost;PathPrefix:/api"

Any suggestion on how do this this in ECS? Basically, if user comes to / , redirect to /api , otherwise, all requests start with /api.

Thanks in advance!

ldez · 2018-02-26T09:09:26Z

@reflog It's not the good place for questions.

Come to the Traefik community Slack

koliyo · 2018-02-27T08:16:36Z

Ignore this, already resolved! Thanks for this feature!

rjchicago · 2018-08-10T13:48:41Z

Tested and using this feature now - thanks!

for other finding this, here was my simple test...

Labels in docker compose:
- traefik.route1.frontend.rule=PathPrefixStrip:/traefik;PathPrefix:/traefik
- traefik.route2.frontend.rule=Host:traefik.docker-swarm.local
- traefik.route3.frontend.rule=Host:test-traefik.docker-swarm.local

Simple verification:
curl -s http://192.168.99.100/traefik/health | jq
curl -s http://traefik.docker-swarm.local/health | jq
curl -s http://test-traefik.docker-swarm.local/health | jq

In Traefik, this shows as this...

benoitf force-pushed the docker-services branch 2 times, most recently from c5f7099 to 65d36ac Compare March 8, 2017 15:27

emilevauge added status/1-needs-design-review status/2-needs-review labels Mar 8, 2017

emilevauge requested review from vdemeester and emilevauge March 8, 2017 16:35

benoitf force-pushed the docker-services branch 4 times, most recently from a5c29e6 to 6310fdc Compare March 8, 2017 18:33

vdemeester suggested changes Mar 10, 2017

View reviewed changes

benoitf force-pushed the docker-services branch 2 times, most recently from cd36713 to ca74d6d Compare March 10, 2017 16:12

benoitf force-pushed the docker-services branch from ca74d6d to 368f929 Compare March 10, 2017 17:47

vdemeester approved these changes Mar 12, 2017

View reviewed changes

slemeur mentioned this pull request Mar 13, 2017

Use a single port to route all traffic eclipse-che/che#4361

Closed

emilevauge approved these changes Mar 13, 2017

View reviewed changes

benoitf force-pushed the docker-services branch 2 times, most recently from 600596e to d2df258 Compare March 13, 2017 18:51

benoitf force-pushed the docker-services branch from d2df258 to 1158eba Compare March 14, 2017 07:46

timoreimann merged commit 2a61c90 into traefik:master Mar 14, 2017

benoitf deleted the docker-services branch March 14, 2017 10:28

vdemeester added this to the 1.3 milestone Mar 14, 2017

timoreimann added status/3-needs-merge and removed status/1-needs-design-review status/2-needs-review labels Mar 14, 2017

timoreimann mentioned this pull request Mar 19, 2017

traefik.frontend.rule NOT working as expected combination rules. #1312

Closed

dcrystalj mentioned this pull request Mar 21, 2017

Multiple ports per service not working #1321

Closed

emilevauge mentioned this pull request Apr 3, 2017

Add Basic Auth per Frontend #1147

Merged

yajo mentioned this pull request Apr 4, 2017

Add option to force www addition or removal #1380

Closed

ldez added kind/enhancement a new or improved feature. area/provider/docker labels Apr 29, 2017

ldez removed the status/3-needs-merge label May 19, 2017

This was referenced May 30, 2017

Multiple port and site support #61

Closed

sending /<path> to alternative port on same backend #704

Closed

yajo added a commit to Tecnativa/doodba that referenced this pull request Jun 6, 2017

[IMP] Remove 1 proxy from stack

eee1655

Thanks to Traefik 1.3 now we can use only traefik for separating normal Odoo requests from longpolling ones. See traefik/traefik#1257.

aantono mentioned this pull request Jun 28, 2017

Support multi-port service routing for containers running on Marathon #1742

Merged

smueller18 mentioned this pull request Sep 4, 2017

Feature Request: Allow multiple rules from Rancher labels containers #2052

Closed

pixystone mentioned this pull request Jan 8, 2018

Added Traefik's docker.network label to fix multiuser single_port eclipse-che/che#7170

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow multiple rules from docker labels containers with traefik.<servicename>.* properties #1257

Allow multiple rules from docker labels containers with traefik.<servicename>.* properties #1257

benoitf commented Mar 8, 2017

vdemeester left a comment

vdemeester Mar 10, 2017

benoitf Mar 10, 2017

vdemeester Mar 10, 2017

benoitf Mar 10, 2017

vdemeester Mar 10, 2017

benoitf Mar 10, 2017 •

edited

Loading

vdemeester Mar 10, 2017

benoitf Mar 10, 2017

benoitf commented Mar 10, 2017

benoitf commented Mar 11, 2017

vdemeester left a comment

emilevauge left a comment

benoitf commented Mar 13, 2017

timoreimann commented Mar 14, 2017 •

edited

Loading

benoitf commented Mar 14, 2017

vdemeester commented Mar 14, 2017

benoitf commented Mar 14, 2017

dcrystalj commented Mar 21, 2017 •

edited

Loading

timoreimann commented Mar 21, 2017

alwaysastudent commented Apr 3, 2017

reflog commented Feb 26, 2018

ldez commented Feb 26, 2018

reflog commented Feb 26, 2018

ldez commented Feb 26, 2018

koliyo commented Feb 27, 2018 •

edited

Loading

rjchicago commented Aug 10, 2018 •

edited

Loading

Allow multiple rules from docker labels containers with traefik.<servicename>.* properties #1257

Allow multiple rules from docker labels containers with traefik.<servicename>.* properties #1257

Conversation

benoitf commented Mar 8, 2017

vdemeester left a comment

Choose a reason for hiding this comment

vdemeester Mar 10, 2017

Choose a reason for hiding this comment

benoitf Mar 10, 2017

Choose a reason for hiding this comment

vdemeester Mar 10, 2017

Choose a reason for hiding this comment

benoitf Mar 10, 2017

Choose a reason for hiding this comment

vdemeester Mar 10, 2017

Choose a reason for hiding this comment

benoitf Mar 10, 2017 • edited Loading

Choose a reason for hiding this comment

vdemeester Mar 10, 2017

Choose a reason for hiding this comment

benoitf Mar 10, 2017

Choose a reason for hiding this comment

benoitf commented Mar 10, 2017

benoitf commented Mar 11, 2017

vdemeester left a comment

Choose a reason for hiding this comment

emilevauge left a comment

Choose a reason for hiding this comment

benoitf commented Mar 13, 2017

timoreimann commented Mar 14, 2017 • edited Loading

benoitf commented Mar 14, 2017

vdemeester commented Mar 14, 2017

benoitf commented Mar 14, 2017

dcrystalj commented Mar 21, 2017 • edited Loading

timoreimann commented Mar 21, 2017

alwaysastudent commented Apr 3, 2017

reflog commented Feb 26, 2018

ldez commented Feb 26, 2018

reflog commented Feb 26, 2018

ldez commented Feb 26, 2018

koliyo commented Feb 27, 2018 • edited Loading

rjchicago commented Aug 10, 2018 • edited Loading

benoitf Mar 10, 2017 •

edited

Loading

timoreimann commented Mar 14, 2017 •

edited

Loading

dcrystalj commented Mar 21, 2017 •

edited

Loading

koliyo commented Feb 27, 2018 •

edited

Loading

rjchicago commented Aug 10, 2018 •

edited

Loading